Skip to content
Snippets Groups Projects
  • Nicolò Pretto's avatar
    584eddc0
    [Move card to tab] Milestone 4 - polishment (#35240) · 584eddc0
    Nicolò Pretto authored
    
    * empty commit to allow draft pr
    
    * dismiss undo notifications when saving a dashboard (#35243)
    
    * dismiss undo notifications when saving a dashboard
    
    * e2e test
    
    * Update e2e/test/scenarios/dashboard/tabs.cy.spec.js
    
    Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    
    ---------
    
    Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    
    * fix z-index issues
    
    * Update frontend/src/metabase/dashboard/components/DashCard/DashCard.styled.tsx
    
    Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
    
    * renames as per feedback on PR
    
    * left align dashcard actions on small cards (#35327)
    
    * update emotion to support container queries
    
    * left align actions with container query
    
    * use rems
    
    * fix restore z index between resize handle and dashcard actions
    
    * refactor: remove renderDashCardActions in favor of a component (#35366)
    
    * move DashboardCardActionsPanel inside DashCardActionButtons
    
    * move isDashCardTabMenuOpen state to DashCardACtionsButtons
    
    * refactor: remove renderDashCardActions
    
    * refactor: renamed to DashCardActionsPanel
    
    * refactor import type MouseEvent
    
    * refactor DashCardActionButtons folder -> DashCardActionsPanel
    
    * refactor: move DashCardTabMenu to DashCardActionsPanel
    
    * refactor: move buttons to their own subfolder so that it's clear they're sub-components of the actions panel
    
    * feat: use name of card in undo toast message (#35378)
    
    * feat: use name of card in undo toast message
    
    * feat/refactor: truncate via css
    
    * denis' patch to use Ellipsified
    
    * make toast don't take up all space + add max width
    
    * Update frontend/src/metabase/containers/UndoListing.styled.tsx
    
    Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
    
    ---------
    
    Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
    
    ---------
    
    Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
    Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
    [Move card to tab] Milestone 4 - polishment (#35240)
    Nicolò Pretto authored
    
    * empty commit to allow draft pr
    
    * dismiss undo notifications when saving a dashboard (#35243)
    
    * dismiss undo notifications when saving a dashboard
    
    * e2e test
    
    * Update e2e/test/scenarios/dashboard/tabs.cy.spec.js
    
    Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    
    ---------
    
    Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    
    * fix z-index issues
    
    * Update frontend/src/metabase/dashboard/components/DashCard/DashCard.styled.tsx
    
    Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
    
    * renames as per feedback on PR
    
    * left align dashcard actions on small cards (#35327)
    
    * update emotion to support container queries
    
    * left align actions with container query
    
    * use rems
    
    * fix restore z index between resize handle and dashcard actions
    
    * refactor: remove renderDashCardActions in favor of a component (#35366)
    
    * move DashboardCardActionsPanel inside DashCardActionButtons
    
    * move isDashCardTabMenuOpen state to DashCardACtionsButtons
    
    * refactor: remove renderDashCardActions
    
    * refactor: renamed to DashCardActionsPanel
    
    * refactor import type MouseEvent
    
    * refactor DashCardActionButtons folder -> DashCardActionsPanel
    
    * refactor: move DashCardTabMenu to DashCardActionsPanel
    
    * refactor: move buttons to their own subfolder so that it's clear they're sub-components of the actions panel
    
    * feat: use name of card in undo toast message (#35378)
    
    * feat: use name of card in undo toast message
    
    * feat/refactor: truncate via css
    
    * denis' patch to use Ellipsified
    
    * make toast don't take up all space + add max width
    
    * Update frontend/src/metabase/containers/UndoListing.styled.tsx
    
    Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
    
    ---------
    
    Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
    
    ---------
    
    Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
    Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
    Co-authored-by: default avatarMahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
This project manages its dependencies using Yarn. Learn more