Skip to content
Snippets Groups Projects
  • Paul Rosenzweig's avatar
    c4353a1f
    Dashboard interactivity: custom drill through and chained filters (#13354) · c4353a1f
    Paul Rosenzweig authored
    
    * dashboard interactivity: custom drill through and chained filters
    
    (cherry picked from commit f3ea3099da981c967fcffd5c7e318c88064c0a96)
    
    * add missing param
    
    * Better error message & test for cases where you don't have Field perms
    
    (cherry picked from commit 2ae8174c388a105170bb316b6266b900f8844c62)
    
    * Fix lint error
    
    (cherry picked from commit aa967359ecf9705f28dded2b5b30eb42ebec156e)
    
    * type another letter to avoid ordering issue
    
    (cherry picked from commit 5f285219c07eeff41b3d1fbfc091092a6ce60ed4)
    
    * fix failing cy tests
    
    (cherry picked from commit 8dbb9561a21f853a550d4ab1385fbdf142ea36e6)
    
    * update test
    
    * Fix merge
    
    * sort correctly
    
    * Fix namespace decl sorting
    
    * use another within block for the "add to dash" modal
    
    Co-authored-by: default avatarCam Saul <github@camsaul.com>
    Dashboard interactivity: custom drill through and chained filters (#13354)
    Paul Rosenzweig authored
    
    * dashboard interactivity: custom drill through and chained filters
    
    (cherry picked from commit f3ea3099da981c967fcffd5c7e318c88064c0a96)
    
    * add missing param
    
    * Better error message & test for cases where you don't have Field perms
    
    (cherry picked from commit 2ae8174c388a105170bb316b6266b900f8844c62)
    
    * Fix lint error
    
    (cherry picked from commit aa967359ecf9705f28dded2b5b30eb42ebec156e)
    
    * type another letter to avoid ordering issue
    
    (cherry picked from commit 5f285219c07eeff41b3d1fbfc091092a6ce60ed4)
    
    * fix failing cy tests
    
    (cherry picked from commit 8dbb9561a21f853a550d4ab1385fbdf142ea36e6)
    
    * update test
    
    * Fix merge
    
    * sort correctly
    
    * Fix namespace decl sorting
    
    * use another within block for the "add to dash" modal
    
    Co-authored-by: default avatarCam Saul <github@camsaul.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
.dir-locals.el 2.38 KiB
((nil . ((indent-tabs-mode . nil)       ; always use spaces for tabs
         (require-final-newline . t)))  ; add final newline on save
 (js2-mode . ((js2-mode-show-parse-errors . nil)      ; these settings will let flycheck do everything through eslint,
              (js2-mode-show-strict-warnings . nil))) ; because js2-mode can't handle flowtype
 (clojure-mode . ((eval . (progn
                            ;; Specify which arg is the docstring for certain macros
                            ;; (Add more as needed)
                            (put 'defendpoint 'clojure-doc-string-elt 3)
                            (put 'defendpoint-async 'clojure-doc-string-elt 3)
                            (put 'api/defendpoint 'clojure-doc-string-elt 3)
                            (put 'api/defendpoint-async 'clojure-doc-string-elt 3)
                            (put 'defsetting 'clojure-doc-string-elt 2)
                            (put 'setting/defsetting 'clojure-doc-string-elt 2)
                            (put 's/defn 'clojure-doc-string-elt 2)
                            (put 'p.types/defprotocol+ 'clojure-doc-string-elt 2)

                            ;; Define custom indentation for functions inside metabase.
                            ;; This list isn't complete; add more forms as we come across them.
                            (define-clojure-indent
                              (let-404 1)
                              (match 1)
                              (merge-with 1)
                              (l/matche '(1 (:defn)))
                              (l/matcha '(1 (:defn)))
                              (p.types/defprotocol+ '(1 (:defn)))
                              (p.types/def-abstract-type '(1 (:defn)))
                              (p.types/deftype+ '(2 nil nil (:defn)))
                              (p/def-map-type '(2 nil nil (:defn)))
                              (p.types/defrecord+ '(2 nil nil (:defn))))))
                  ;; if you're using clj-refactor (highly recommended!), prefer prefix notation when cleaning the ns form
                  (cljr-favor-prefix-notation . t)
                  ;; prefer keeping source width about ~118, GitHub seems to cut off stuff at either 119 or 120 and
                  ;; it's nicer to look at code in GH when you don't have to scroll back and forth
                  (fill-column . 118)
                  (clojure-docstring-fill-column . 118))))