Skip to content
Snippets Groups Projects
  • Jesse Devaney's avatar
    3287965d
    New Dashboard Primitive - Headings (#30804) · 3287965d
    Jesse Devaney authored
    * initial prototype commit
    
    * add default value for text cards
    
    * auto focus text/heading cards on creation
    
    * remove default value - use placeholders instead
    
    * fix inability to edit when there is no heading value
    
    * remove unnecessary comment
    
    * re-word heading & text tooltip
    
    * refactor and fix draggable area bug
    
    * fix border artifacts when combined with dragging styling
    
    * fix stroke width for hovering and focused - make them the same
    
    * display placeholder value in editing mode if content is empty for text and heading dash-cards
    
    * remove duplicate placeholders
    
    * allow pointer-events anywhere on the div (not just content)
    
    * refactor styling to apply no content borders
    
    * Fix heading overflow
    
    * refactor text dash-card button
    
    - remove unnecessary redux store usage
    
    * refactor border styling to one css format
    
    * rename class names to match syntax conventions
    
    * refactor auto-preview styling for dash-card root
    
    * refactor style name
    
    * remove comment
    
    * undo unnecessary re-formatting
    
    * refactor popover styling
    
    * remove comment that was previously addressed
    
    * refactor to typescript
    
    * remove comment
    
    * remove un-used code
    
    * fix TypeScript errors in text unit spec
    
    * update button key and event description
    
    * add e2e tests for text and heading dash-cards
    
    * add e2e tests
    
    * add small heading unit tests
    
    * fix typescript error
    
    * add aria-label removed by merging with master
    
    * fix broken test
    
    * fix broken tests
    
    * fix typescript errors
    
    * align edit text with preview text
    
    * change from hover editing to click editing
    
    * update tests for click editing
    
    - remove hover tests
    - change focus tests to click tests
    - remove top-level findByText() calls
    
    * refactor to use-focus hook
    
    * add "heading" to getSupportedCardsForSubscriptions
    
    * rename showVisualizationOptions to showDashcardVisualizationSettings
    
    * add aria label to buttons and query in tests by label
    
    * refactor E2E tests to make longer flows
    
    * add existing metabase types to Heading
    
    * refactor heading and text menu to use EntityMenu
    
    * fix aria-label
    
    * [skip ci] fix css syntax error from missing semi-colon
    
    * adjust styles and use rem value standards
    
    * [skip ci] prevent drag on click to edit surface area
    
    * tweak styles for mobile resolutions
    
    * fix react import lint error
    
    * fix E2E tests
    
    * refactor e2e helper to shorthand
    
    * refactor to use e2e helper
    
    * refactor to use saveDashboard() e2e helper
    
    * refactor e2e tests
    
    * rename styling variables
    
    * null coalesce minWidth
    
    * remove unnecessary anonymous function wrapping
    
    * refactor to useToggle
    
    * improve no content check
    
    * use object creation shorthand
    
    * simplify expression
    
    * refactor empty content styling
    
    * move text-edit-container styling into heading and text components
    
    * refactor resize handle styling and abstract condition into function
    
    * refactor to use CSS function for string styling
    
    * improve Heading unit tests
    
    * improve Text unit tests
    
    * update Heading and Text unit tests
    
    * update for new Icons
    
    * fix E2E tests
    
    * refactor E2E test assertions
    
    * refactor click events to use user-event library
    
    * fix tooltip positioning
    New Dashboard Primitive - Headings (#30804)
    Jesse Devaney authored
    * initial prototype commit
    
    * add default value for text cards
    
    * auto focus text/heading cards on creation
    
    * remove default value - use placeholders instead
    
    * fix inability to edit when there is no heading value
    
    * remove unnecessary comment
    
    * re-word heading & text tooltip
    
    * refactor and fix draggable area bug
    
    * fix border artifacts when combined with dragging styling
    
    * fix stroke width for hovering and focused - make them the same
    
    * display placeholder value in editing mode if content is empty for text and heading dash-cards
    
    * remove duplicate placeholders
    
    * allow pointer-events anywhere on the div (not just content)
    
    * refactor styling to apply no content borders
    
    * Fix heading overflow
    
    * refactor text dash-card button
    
    - remove unnecessary redux store usage
    
    * refactor border styling to one css format
    
    * rename class names to match syntax conventions
    
    * refactor auto-preview styling for dash-card root
    
    * refactor style name
    
    * remove comment
    
    * undo unnecessary re-formatting
    
    * refactor popover styling
    
    * remove comment that was previously addressed
    
    * refactor to typescript
    
    * remove comment
    
    * remove un-used code
    
    * fix TypeScript errors in text unit spec
    
    * update button key and event description
    
    * add e2e tests for text and heading dash-cards
    
    * add e2e tests
    
    * add small heading unit tests
    
    * fix typescript error
    
    * add aria-label removed by merging with master
    
    * fix broken test
    
    * fix broken tests
    
    * fix typescript errors
    
    * align edit text with preview text
    
    * change from hover editing to click editing
    
    * update tests for click editing
    
    - remove hover tests
    - change focus tests to click tests
    - remove top-level findByText() calls
    
    * refactor to use-focus hook
    
    * add "heading" to getSupportedCardsForSubscriptions
    
    * rename showVisualizationOptions to showDashcardVisualizationSettings
    
    * add aria label to buttons and query in tests by label
    
    * refactor E2E tests to make longer flows
    
    * add existing metabase types to Heading
    
    * refactor heading and text menu to use EntityMenu
    
    * fix aria-label
    
    * [skip ci] fix css syntax error from missing semi-colon
    
    * adjust styles and use rem value standards
    
    * [skip ci] prevent drag on click to edit surface area
    
    * tweak styles for mobile resolutions
    
    * fix react import lint error
    
    * fix E2E tests
    
    * refactor e2e helper to shorthand
    
    * refactor to use e2e helper
    
    * refactor to use saveDashboard() e2e helper
    
    * refactor e2e tests
    
    * rename styling variables
    
    * null coalesce minWidth
    
    * remove unnecessary anonymous function wrapping
    
    * refactor to useToggle
    
    * improve no content check
    
    * use object creation shorthand
    
    * simplify expression
    
    * refactor empty content styling
    
    * move text-edit-container styling into heading and text components
    
    * refactor resize handle styling and abstract condition into function
    
    * refactor to use CSS function for string styling
    
    * improve Heading unit tests
    
    * improve Text unit tests
    
    * update Heading and Text unit tests
    
    * update for new Icons
    
    * fix E2E tests
    
    * refactor E2E test assertions
    
    * refactor click events to use user-event library
    
    * fix tooltip positioning
Code owners
Assign users and groups as approvers for specific file changes. Learn more.