Skip to content
Snippets Groups Projects
  • Mahatthana (Kelvin) Nomsawadi's avatar
    ffa54f0f
    [Milestone 1] Re-design transparent theme for static embedding and public links (#45633) · ffa54f0f
    Mahatthana (Kelvin) Nomsawadi authored
    
    * refactor: Simplify code (#44275)
    
    * Remove dead code
    
    * Remove values same as default options
    
    * Simplify hook API: Removing unused argument
    
    * review: Remove redundant code
    
    * Update look and feel copy (#44277)
    
    * Update static embed tab name
    
    * Update copies + rearrange settings
    
    * Use Mantine Select
    
    * Fix E2E tests by applying new copies
    
    * Fix unit tests
    
    * Fix more E2E tests
    
    * review: Add a comment on Mantine `value` quirk
    
    * Adjust spacing and relevant tests
    
    * Move `transparent` theme to its own toggle option (#44362)
    
    * Reorder the function to match the visual order
    
    * Make function name consistent
    
    * Introduce the new background option (do nothing yet)
    
    * Remove redundant exports
    
    * Tighten up values to reduce confusion
    
    * Make the parameters order consistent
    
    * Only show background option on dashboads (spec)
    
    * Allow dashboard embed background to be transparent
    
    * Make filter background and header/footer transparent
    
    * Fix type error
    
    * Fix unit tests
    
    * Fix E2E tests
    
    * Fix checkerboard pattern not showing when no background
    
    * Add unit tests
    
    * Add missing copy update
    
    * Remove remnants from outdated solutions within the PR
    
    * Improve code comment references
    
    * Fix E2E tests since the last copy change
    
    * Fix type errors from merging master
    
    * Update light theme style (#44488)
    
    * Add background to dashboard filter on light theme
    
    * Make position sticky works with transparent background
    
    * Fix sticky filters not working on theme=transparent
    
    * Fix unit tests
    
    * Simplify IntersectionObserver components + fix E2E tests
    
    * Add storybook for embedded dashboard
    
    * Clarify the use of ExplicitSize context
    
    * Remove unused code
    
    * Formatting
    
    * Review: Better mock `isWithinIframe`
    
    * Update dark theme to match the new design (#45134)
    
    * Update light theme checkerboard colors
    
    * Update checkerboard colors
    
    * Consolidate dashboard light/dark border style
    
    * Use `--mb-color-text-primary` for light theme dashboard
    
    * Update embed dashboard dark theme primary color
    
    * Migrate dashboard text-secondary color
    
    * Migrate text-tertiary color
    
    * Migrate gold, axis, and split line to CSS custom properties
    
    * Fix failed e2e tests
    
    * Fix static viz not working
    
    * Update loki snapshots
    
    * Remove unnecessary CSS custom property
    
    * Make diff more consistent
    
    * Address review: reusing type
    
    * Support backward compatibility when passing `theme=transparent` (#45214)
    
    * Match preview query with the actual code query
    
    * Handle backward compatibility when `theme=transparent` on dashboard
    
    * Add unit tests
    
    * Address review: Make tests less repetitive
    
    * Update Metabase banner upsell UI (#45424)
    
    * Prepare folder for nested components
    
    * Update upsell UI
    
    - add `fullWidth` variant
    - align title to the left
    
    * Fix Upsell banner having horizontal scroll on full width
    
    * Add new Metabase banner upsell component
    
    * Fix unit tests
    
    * Address review: Fix typo
    
    Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
    
    * Address review: Move upsel UI to `admin/upsells`
    
    Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
    
    * Remove unnecessary ESLint disable comment
    
    We can remove it since the file is in admin folder, and is already excluded from the rule.
    
    * Address review: remove default value property
    
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    
    * Address review: Extract magic number
    
    ---------
    
    Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    
    * More UI updates (#45450)
    
    * Update dark theme text colors to match the new design
    
    * Update powered by metabase logo
    
    * Update loki snapshots
    
    * Fix unit tests
    
    * Fix formatting
    
    * Fix wrong dark theme metabase logo badge color
    
    * Address review: Compress SVG with svgo
    
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    
    * Fix E2E tests
    
    * Update loki snapshots
    
    * Clarify Metabase base colors with comments
    
    ---------
    
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    
    * Add more tests (#45628)
    
    * Add static embed question stories
    
    * Add loki snapshots
    
    * Add transparent theme for static dashboard tests
    
    * Add transparent theme tests for static questions
    
    * Assert `background` option in analytics tests
    
    * Remove tests for logic that has been moved
    
    * Update loki snapshots
    
    * Fix failed E2E tests from merging master
    
    ---------
    
    Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    [Milestone 1] Re-design transparent theme for static embedding and public links (#45633)
    Mahatthana (Kelvin) Nomsawadi authored
    
    * refactor: Simplify code (#44275)
    
    * Remove dead code
    
    * Remove values same as default options
    
    * Simplify hook API: Removing unused argument
    
    * review: Remove redundant code
    
    * Update look and feel copy (#44277)
    
    * Update static embed tab name
    
    * Update copies + rearrange settings
    
    * Use Mantine Select
    
    * Fix E2E tests by applying new copies
    
    * Fix unit tests
    
    * Fix more E2E tests
    
    * review: Add a comment on Mantine `value` quirk
    
    * Adjust spacing and relevant tests
    
    * Move `transparent` theme to its own toggle option (#44362)
    
    * Reorder the function to match the visual order
    
    * Make function name consistent
    
    * Introduce the new background option (do nothing yet)
    
    * Remove redundant exports
    
    * Tighten up values to reduce confusion
    
    * Make the parameters order consistent
    
    * Only show background option on dashboads (spec)
    
    * Allow dashboard embed background to be transparent
    
    * Make filter background and header/footer transparent
    
    * Fix type error
    
    * Fix unit tests
    
    * Fix E2E tests
    
    * Fix checkerboard pattern not showing when no background
    
    * Add unit tests
    
    * Add missing copy update
    
    * Remove remnants from outdated solutions within the PR
    
    * Improve code comment references
    
    * Fix E2E tests since the last copy change
    
    * Fix type errors from merging master
    
    * Update light theme style (#44488)
    
    * Add background to dashboard filter on light theme
    
    * Make position sticky works with transparent background
    
    * Fix sticky filters not working on theme=transparent
    
    * Fix unit tests
    
    * Simplify IntersectionObserver components + fix E2E tests
    
    * Add storybook for embedded dashboard
    
    * Clarify the use of ExplicitSize context
    
    * Remove unused code
    
    * Formatting
    
    * Review: Better mock `isWithinIframe`
    
    * Update dark theme to match the new design (#45134)
    
    * Update light theme checkerboard colors
    
    * Update checkerboard colors
    
    * Consolidate dashboard light/dark border style
    
    * Use `--mb-color-text-primary` for light theme dashboard
    
    * Update embed dashboard dark theme primary color
    
    * Migrate dashboard text-secondary color
    
    * Migrate text-tertiary color
    
    * Migrate gold, axis, and split line to CSS custom properties
    
    * Fix failed e2e tests
    
    * Fix static viz not working
    
    * Update loki snapshots
    
    * Remove unnecessary CSS custom property
    
    * Make diff more consistent
    
    * Address review: reusing type
    
    * Support backward compatibility when passing `theme=transparent` (#45214)
    
    * Match preview query with the actual code query
    
    * Handle backward compatibility when `theme=transparent` on dashboard
    
    * Add unit tests
    
    * Address review: Make tests less repetitive
    
    * Update Metabase banner upsell UI (#45424)
    
    * Prepare folder for nested components
    
    * Update upsell UI
    
    - add `fullWidth` variant
    - align title to the left
    
    * Fix Upsell banner having horizontal scroll on full width
    
    * Add new Metabase banner upsell component
    
    * Fix unit tests
    
    * Address review: Fix typo
    
    Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
    
    * Address review: Move upsel UI to `admin/upsells`
    
    Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
    
    * Remove unnecessary ESLint disable comment
    
    We can remove it since the file is in admin folder, and is already excluded from the rule.
    
    * Address review: remove default value property
    
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    
    * Address review: Extract magic number
    
    ---------
    
    Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    
    * More UI updates (#45450)
    
    * Update dark theme text colors to match the new design
    
    * Update powered by metabase logo
    
    * Update loki snapshots
    
    * Fix unit tests
    
    * Fix formatting
    
    * Fix wrong dark theme metabase logo badge color
    
    * Address review: Compress SVG with svgo
    
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    
    * Fix E2E tests
    
    * Update loki snapshots
    
    * Clarify Metabase base colors with comments
    
    ---------
    
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
    
    * Add more tests (#45628)
    
    * Add static embed question stories
    
    * Add loki snapshots
    
    * Add transparent theme for static dashboard tests
    
    * Add transparent theme tests for static questions
    
    * Assert `background` option in analytics tests
    
    * Remove tests for logic that has been moved
    
    * Update loki snapshots
    
    * Fix failed E2E tests from merging master
    
    ---------
    
    Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
    Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
This project manages its dependencies using yarn. Learn more