Skip to content
Snippets Groups Projects
  • Dalton's avatar
    a362e2f3
    Dashboard parameter field filter operators feature flag (#15519) · a362e2f3
    Dalton authored
    
    * Backend feature flag for new field filters
    
    * Feature flag new parameter options
    
    When the "field-filter-operators-enabled?" flag is disabled we do the following:
    1. Replace new operator options with old category and location/city, etc., options
       in the PARAMETER_OPTIONS list found in metabase/meta/Parameter.js
    2. Hide numbers section in the PARAMETER_SECTIONS list found in
       metabase/meta/Dashboard.js
    3. Return args as-is in the mapUIParameterToQueryParameter function
       found in metabase/meta/Parameter.js
    
    React/UI code handles both old options and new options so doesn't need
    to change. Old parameter types like "category" and "location/city" are
    treated like "string/=" in the UI but retain their own parameter type
    when used to send a new query.
    
    * Fix FE issues caused by meta/Parameter refactor
    
    * mock the field operator param flag to make tests pass
    
    * add/fix cypress tests
    
    * fix import in ParametersPopover
    
    * update widget tag type
    
    * Enable field filter operators for cypress tests
    
    * Question marks are questionable
    
    * Conditionally use category or string/= if field filters are enabled
    
    * rmv mocks where we don't need them
    
    * rmv mock from chained-filters test
    
    * env vars as string in project.clj, alignment
    
    Co-authored-by: default avatardan sutton <dan@dpsutton.com>
    Dashboard parameter field filter operators feature flag (#15519)
    Dalton authored
    
    * Backend feature flag for new field filters
    
    * Feature flag new parameter options
    
    When the "field-filter-operators-enabled?" flag is disabled we do the following:
    1. Replace new operator options with old category and location/city, etc., options
       in the PARAMETER_OPTIONS list found in metabase/meta/Parameter.js
    2. Hide numbers section in the PARAMETER_SECTIONS list found in
       metabase/meta/Dashboard.js
    3. Return args as-is in the mapUIParameterToQueryParameter function
       found in metabase/meta/Parameter.js
    
    React/UI code handles both old options and new options so doesn't need
    to change. Old parameter types like "category" and "location/city" are
    treated like "string/=" in the UI but retain their own parameter type
    when used to send a new query.
    
    * Fix FE issues caused by meta/Parameter refactor
    
    * mock the field operator param flag to make tests pass
    
    * add/fix cypress tests
    
    * fix import in ParametersPopover
    
    * update widget tag type
    
    * Enable field filter operators for cypress tests
    
    * Question marks are questionable
    
    * Conditionally use category or string/= if field filters are enabled
    
    * rmv mocks where we don't need them
    
    * rmv mock from chained-filters test
    
    * env vars as string in project.clj, alignment
    
    Co-authored-by: default avatardan sutton <dan@dpsutton.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.