Skip to content
Snippets Groups Projects
  • Bryan Maass's avatar
    c46337ad
    insert next-gen permission paths alongside currently active permission paths +... · c46337ad
    Bryan Maass authored
    insert next-gen permission paths alongside currently active permission paths + classification (#27911)
    
    * implement move, which returns v2 paths
    
    - TODO: insert these into the db
    
    (move v1-path) => [v2 paths]
    
    * cleanup + add some schemas
    
    * generative tests 4 permission path classification
    
    * whitespace lint
    
    * detect data, query, and paths for v2
    
    * calling move on v2 paths is a no-op
    
    * differentiate between v1 and v2 permissions
    
    quickchecking for move, classify-path, and classify-data-path
    
    * fix tests + add idempotency test
    
    * add tests for classification of permission paths
    
    - rename move to ->v2-path
    - move some fxns around
    - ascii art in test
    
    * making the legos line up
    
    - need to insert both v1 and v2 versions of paths (of course)
    - valid-path? has to allow v2 paths to be inserted
    
    * replace mu/with-api-error-message
    
    * linter + code quality fixes
    
    * privatize rx->kind
    
    * remove some changes that should be 4 anotherbranch
    
    * revert ns
    
    * delete v2 permissions in
    
    - they aren't handled by the perm graph parser, so they don't get propagated into "old graph", so the diff between old and new indicates that they need to be rewritten.
    
    * only delete v2 paths for the current group_id
    
    - reorder declarations in models.permissions
    
    * remove extra line break
    
    * Update src/metabase/models/permissions.clj
    
    fix typo
    
    Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
    insert next-gen permission paths alongside currently active permission paths +...
    Bryan Maass authored
    insert next-gen permission paths alongside currently active permission paths + classification (#27911)
    
    * implement move, which returns v2 paths
    
    - TODO: insert these into the db
    
    (move v1-path) => [v2 paths]
    
    * cleanup + add some schemas
    
    * generative tests 4 permission path classification
    
    * whitespace lint
    
    * detect data, query, and paths for v2
    
    * calling move on v2 paths is a no-op
    
    * differentiate between v1 and v2 permissions
    
    quickchecking for move, classify-path, and classify-data-path
    
    * fix tests + add idempotency test
    
    * add tests for classification of permission paths
    
    - rename move to ->v2-path
    - move some fxns around
    - ascii art in test
    
    * making the legos line up
    
    - need to insert both v1 and v2 versions of paths (of course)
    - valid-path? has to allow v2 paths to be inserted
    
    * replace mu/with-api-error-message
    
    * linter + code quality fixes
    
    * privatize rx->kind
    
    * remove some changes that should be 4 anotherbranch
    
    * revert ns
    
    * delete v2 permissions in
    
    - they aren't handled by the perm graph parser, so they don't get propagated into "old graph", so the diff between old and new indicates that they need to be rewritten.
    
    * only delete v2 paths for the current group_id
    
    - reorder declarations in models.permissions
    
    * remove extra line break
    
    * Update src/metabase/models/permissions.clj
    
    fix typo
    
    Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: default avatarmetamben <103100869+metamben@users.noreply.github.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.