Skip to content
Snippets Groups Projects
  • Mahatthana (Kelvin) Nomsawadi's avatar
    279b3721
    Add ESLint rule for Metabase strings (#38553) · 279b3721
    Mahatthana (Kelvin) Nomsawadi authored
    * Fix case where Metabase links are render inside template strings
    
    * Add `no-literal-metabase-strings` ESLint rule
    
    * Fix all Metabase string errors
    
    * Address review: Fix the rule
    
    The rule was checking if we have imported the selector
    `getApplicationName` then ignore all Metabase strings. This is different
    than `no-unconditional-metabase-links-render` because in that rule, when
    fixed the Documentation URLs are still in the file, but in this rule,
    when fixed, there should be no Metabase strings left in the file.
    
    * Fix errors from the new lint rule
    279b3721
    History
    Add ESLint rule for Metabase strings (#38553)
    Mahatthana (Kelvin) Nomsawadi authored
    * Fix case where Metabase links are render inside template strings
    
    * Add `no-literal-metabase-strings` ESLint rule
    
    * Fix all Metabase string errors
    
    * Address review: Fix the rule
    
    The rule was checking if we have imported the selector
    `getApplicationName` then ignore all Metabase strings. This is different
    than `no-unconditional-metabase-links-render` because in that rule, when
    fixed the Documentation URLs are still in the file, but in this rule,
    when fixed, there should be no Metabase strings left in the file.
    
    * Fix errors from the new lint rule
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
.eslintrc 5.53 KiB