-
Robert Roland authored
* Dashboard subscriptions work, squashed This test namespace differs in EE and OSS Without other changes from EE, this won't work so, for now, I've restored the pure OSS version of this test redo wording on existing subscription cards hacks? to address some timing issues where the render loop executes before properties are available (loaded from the server) links to configure pulse types Display a link to configure email or slack when they aren't already Fix the am/pm picker set up a new schedule tooltip The sidebar can appear and disappear from the Sharing popover run prettier on everything email recipients now does the "name [and n other]" thing Dashboard subscriptions work, squashed redo wording on existing subscription cards hacks? to address some timing issues where the render loop executes before properties are available (loaded from the server) styling for email not configured state add styling for slack unconfigured state disable cursor-pointer if email or slack isn't configured Implement cancel button for the sidebar (#13741) Dashboard subscription UX enhancements: * Implement cancel button for the sidebar * Don't return duplicate dashboard subscriptions * Move sidebar cancellation into Redux * Add close icon * Fix popover behavior Dashboard Subscriptions: Fix build (#13859) * Frontend lint fixes * Fix failing email tests * Revert some of the snapshot changes * regenerate snapshots * done fixing FE tests? * Make `dashboard_card_id` optional in CardRef schema * Fix test setup in pulse model test * Fix collection API test * Order pulses by name * Cypress fixes/skips Co-authored-by:
Paul Rosenzweig <paul.a.rosenzweig@gmail.com> Subscribe to dashboards send test email (#13886) * Frontend lint fixes * Fix failing email tests * Revert some of the snapshot changes * regenerate snapshots * done fixing FE tests? * Make `dashboard_card_id` optional in CardRef schema * Fix test setup in pulse model test * Fix collection API test * Order pulses by name * Cypress fixes/skips * uggh cypress * Add button to send test email for dashboard subscriptions * Disable test email with no recipients * Refactor SendTestEmail Co-authored-by:
Paul Rosenzweig <paul.a.rosenzweig@gmail.com> Fix failing collection tests (#13891) * Move dashboard embedding button (#13928) * Revert migration 277 (as in master) styling and hover tweaks for subscription cards (#14003) Fix positioning of create and close buttons (#13999) * fix positioning of create and close buttons * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx * import Flex Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> Co-authored-by:
Kyle Doherty <kyle.l.doherty@gmail.com> Add deprecation warning to Pulse create/edit page (#13954) * add pulse deprecation warning * remove unused Link component * kyle comments * Update frontend/src/metabase/pulse/components/PulseEdit.jsx Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> * Update frontend/src/metabase/pulse/components/PulseEdit.jsx Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> * Update frontend/src/metabase/pulse/components/PulseEdit.jsx Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> More dash subscription styling tweaks (#14006) * change hovers for email and slack delivery options * calm down, delete button * style csv and xlsx options as buttongroup * settings spacing tweaks Dashboard subscription attachment question selection (#13950) * Move email attachment into its own component Add appropriate checkbox behavior Set pulseCards appropriately * Delete PulseCards when dashboard card removed Co-authored-by:
Cam Saul <github@camsaul.com>
Robert Roland authored* Dashboard subscriptions work, squashed This test namespace differs in EE and OSS Without other changes from EE, this won't work so, for now, I've restored the pure OSS version of this test redo wording on existing subscription cards hacks? to address some timing issues where the render loop executes before properties are available (loaded from the server) links to configure pulse types Display a link to configure email or slack when they aren't already Fix the am/pm picker set up a new schedule tooltip The sidebar can appear and disappear from the Sharing popover run prettier on everything email recipients now does the "name [and n other]" thing Dashboard subscriptions work, squashed redo wording on existing subscription cards hacks? to address some timing issues where the render loop executes before properties are available (loaded from the server) styling for email not configured state add styling for slack unconfigured state disable cursor-pointer if email or slack isn't configured Implement cancel button for the sidebar (#13741) Dashboard subscription UX enhancements: * Implement cancel button for the sidebar * Don't return duplicate dashboard subscriptions * Move sidebar cancellation into Redux * Add close icon * Fix popover behavior Dashboard Subscriptions: Fix build (#13859) * Frontend lint fixes * Fix failing email tests * Revert some of the snapshot changes * regenerate snapshots * done fixing FE tests? * Make `dashboard_card_id` optional in CardRef schema * Fix test setup in pulse model test * Fix collection API test * Order pulses by name * Cypress fixes/skips Co-authored-by:
Paul Rosenzweig <paul.a.rosenzweig@gmail.com> Subscribe to dashboards send test email (#13886) * Frontend lint fixes * Fix failing email tests * Revert some of the snapshot changes * regenerate snapshots * done fixing FE tests? * Make `dashboard_card_id` optional in CardRef schema * Fix test setup in pulse model test * Fix collection API test * Order pulses by name * Cypress fixes/skips * uggh cypress * Add button to send test email for dashboard subscriptions * Disable test email with no recipients * Refactor SendTestEmail Co-authored-by:
Paul Rosenzweig <paul.a.rosenzweig@gmail.com> Fix failing collection tests (#13891) * Move dashboard embedding button (#13928) * Revert migration 277 (as in master) styling and hover tweaks for subscription cards (#14003) Fix positioning of create and close buttons (#13999) * fix positioning of create and close buttons * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx * Update frontend/src/metabase/sharing/components/SharingSidebar.jsx * import Flex Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> Co-authored-by:
Kyle Doherty <kyle.l.doherty@gmail.com> Add deprecation warning to Pulse create/edit page (#13954) * add pulse deprecation warning * remove unused Link component * kyle comments * Update frontend/src/metabase/pulse/components/PulseEdit.jsx Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> * Update frontend/src/metabase/pulse/components/PulseEdit.jsx Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> * Update frontend/src/metabase/pulse/components/PulseEdit.jsx Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> Co-authored-by:
Kyle Doherty <kdoh@users.noreply.github.com> More dash subscription styling tweaks (#14006) * change hovers for email and slack delivery options * calm down, delete button * style csv and xlsx options as buttongroup * settings spacing tweaks Dashboard subscription attachment question selection (#13950) * Move email attachment into its own component Add appropriate checkbox behavior Set pulseCards appropriately * Delete PulseCards when dashboard card removed Co-authored-by:
Cam Saul <github@camsaul.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.