Skip to content
Snippets Groups Projects
  • Case Nelson's avatar
    63179270
    fix: dont always optimize between expressions (#44493) · 63179270
    Case Nelson authored
    * fix: dont always optimize between expressions
    
    Fixes #42291
    
    The frontend produces expressions like
    
    ```
    [:between
     [+ [:field ... {:temporal-bucket :day] [:interval 2 :day]]
     [:relative-datetime -1 :week]
     [:relative-datetime 0 :week]]
    ```
    
    This should not be optimized because of the mixed `:day` and `:week`
    units. However, it was being optimized since the compatible units
    weren't being properly picked up by the match.
    
    * Disable suspcicios args eastwood lint, kondo does it better
    
    * Stop autobucket to day when adding a time interval
    fix: dont always optimize between expressions (#44493)
    Case Nelson authored
    * fix: dont always optimize between expressions
    
    Fixes #42291
    
    The frontend produces expressions like
    
    ```
    [:between
     [+ [:field ... {:temporal-bucket :day] [:interval 2 :day]]
     [:relative-datetime -1 :week]
     [:relative-datetime 0 :week]]
    ```
    
    This should not be optimized because of the mixed `:day` and `:week`
    units. However, it was being optimized since the compatible units
    weren't being properly picked up by the match.
    
    * Disable suspcicios args eastwood lint, kondo does it better
    
    * Stop autobucket to day when adding a time interval
Code owners
Assign users and groups as approvers for specific file changes. Learn more.