Skip to content
Snippets Groups Projects
Unverified Commit 001e0886 authored by Aleksandr Lesnenko's avatar Aleksandr Lesnenko Committed by GitHub
Browse files

tweak sunburst chart styles (#48421)


* tweak sunburst chart styles

* Update Loki Snapshots

* Update Loki Snapshots

* Update Loki Snapshots

---------

Co-authored-by: default avatarMetabase Automation <github-automation@metabase.com>
parent 4dc135ac
No related branches found
No related tags found
No related merge requests found
Showing
with 11 additions and 12 deletions
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png

67.8 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png

67.8 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_static_viz_PieChart_Labels_With_Percent.png

90.7 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Labels_With_Percent.png

86 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Labels_With_Percent.png
.loki/reference/chrome_laptop_static_viz_PieChart_Labels_With_Percent.png
.loki/reference/chrome_laptop_static_viz_PieChart_Labels_With_Percent.png
.loki/reference/chrome_laptop_static_viz_PieChart_Labels_With_Percent.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings.png

123 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings.png

122 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_No_Labels.png

98 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_No_Labels.png

96.9 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_No_Labels.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_No_Labels.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_No_Labels.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_No_Labels.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Other_Slices.png

98.8 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Other_Slices.png

97.1 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Other_Slices.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Other_Slices.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Other_Slices.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Other_Slices.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_And_Labels.png

109 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_And_Labels.png

108 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_And_Labels.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_And_Labels.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_And_Labels.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_And_Labels.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_On_Chart.png

127 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_On_Chart.png

127 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_On_Chart.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_On_Chart.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_On_Chart.png
.loki/reference/chrome_laptop_static_viz_PieChart_Three_Rings_Percentages_On_Chart.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_static_viz_PieChart_Two_Rings.png

83.8 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Two_Rings.png

78.8 KiB | W: | H:

.loki/reference/chrome_laptop_static_viz_PieChart_Two_Rings.png
.loki/reference/chrome_laptop_static_viz_PieChart_Two_Rings.png
.loki/reference/chrome_laptop_static_viz_PieChart_Two_Rings.png
.loki/reference/chrome_laptop_static_viz_PieChart_Two_Rings.png
  • 2-up
  • Swipe
  • Onion skin
......@@ -236,14 +236,6 @@ function getSeriesDataFromSlices(
return [];
}
let ringBorderWidth = borderWidth;
if (ring === 2) {
ringBorderWidth = DIMENSIONS.slice.twoRingBorderWidth;
}
if (ring === 3) {
ringBorderWidth = DIMENSIONS.slice.threeRingBorderWidth;
}
return slices.map(s => {
const labelColor = getTextColorForBackground(
s.color,
......@@ -272,11 +264,11 @@ function getSeriesDataFromSlices(
: undefined,
value: s.value,
name,
itemStyle: { color: s.color, borderWidth: ringBorderWidth },
itemStyle: { color: s.color, borderWidth },
label: {
color: labelColor,
formatter: () => (isLabelVisible ? label : " "),
rotate: ring === 1 ? 0 : "radial",
rotate: chartModel.numRings === 1 ? 0 : "radial",
},
emphasis: {
itemStyle: {
......@@ -308,6 +300,14 @@ function getSeriesDataFromSlices(
);
}
const getBorderWidth = (innerSideLength: number, ringsCount = 1) => {
if (ringsCount === 1) {
// arc length formula: s = 2πr(θ/360°), we want border to be 1 degree
return (Math.PI * innerSideLength) / DIMENSIONS.slice.borderProportion;
}
return 1;
};
export function getPieChartOption(
chartModel: PieChartModel,
formatters: PieChartFormatters,
......@@ -327,8 +327,7 @@ export function getPieChartOption(
chartModel,
);
const borderWidth =
(Math.PI * innerSideLength) / DIMENSIONS.slice.borderProportion; // arc length formula: s = 2πr(θ/360°), we want border to be 1 degree
const borderWidth = getBorderWidth(innerSideLength, chartModel.numRings);
const fontSize =
chartModel.numRings > 1
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment