download link working again.

resources/frontend_client/app/card/card.controllers.js

@@ -182,13 +182,6 @@ CardControllers.controller('CardDetail', [
 
                     renderAll();
                 }
-            },
-            getDownloadLink: function() {
-                // TODO: this should be conditional and only return a valid url if we have valid
-                //       data to be downloaded.  otherwise return something falsey
-                if (queryResult) {
-                    return '/api/meta/dataset/csv/?query=' + encodeURIComponent(JSON.stringify(card.dataset_query));
-                }
             }
         };
 
@@ -261,6 +254,12 @@ CardControllers.controller('CardDetail', [
             // ensure rendering model is up to date
             headerModel.card = card;
 
+            if (queryResult) {
+                headerModel.downloadLink = '/api/meta/dataset/csv?query=' + encodeURIComponent(JSON.stringify(card.dataset_query));
+            } else {
+                headerModel.downloadLink = null;
+            }
+
             React.render(new QueryHeader(headerModel), document.getElementById('react_qb_header'));
         };
 

src/metabase/api/meta/dataset.clj

@@ -18,7 +18,8 @@
   [query]
   {query [Required String->Dict]}
   (read-check Database (:database query))
-  (let [{{:keys [columns rows]} :data :keys [status] :as response} (driver/dataset-query query {:executed_by *current-user-id*})]
+  (let [{{:keys [columns rows]} :data :keys [status] :as response} (driver/dataset-query query {:executed_by *current-user-id*})
+        columns (map name columns)]                         ; turn keywords into strings, otherwise we get colons in our output
     (if (= status :completed)
       ;; successful query, send CSV file
       {:status 200