Skip to content
Snippets Groups Projects
Unverified Commit 00f1ca7c authored by Ibe Dwi's avatar Ibe Dwi Committed by GitHub
Browse files

Return "parameterId" as "id" in removeParameter action (#34680)

* red: reproduce the error in test case

* green: return id in removeParameter action

* refactor: create dashboard actions parameters unit test

* chore: rename unit test

* fix: update test's issue reference

* chore: add new line
parent cef52044
No related branches found
No related tags found
No related merge requests found
......@@ -105,6 +105,7 @@ export const removeParameter = createThunkAction(
updateParameters(dispatch, getState, parameters =>
parameters.filter(p => p.id !== parameterId),
);
return { id: parameterId };
},
);
......
import { removeParameter, REMOVE_PARAMETER } from "./parameters";
describe("removeParameter", () => {
let dispatch;
let getState;
beforeEach(() => {
dispatch = jest.fn();
getState = () => ({
dashboard: {
dashboardId: 1,
dashboards: {
1: {
id: 1,
parameters: [{ id: 123 }, { id: 456 }],
},
},
parameterValues: {
123: null,
456: null,
},
},
});
});
it("should return the `parameterId` as `payload.id` (metabase#33826)", async () => {
const result = await removeParameter(123)(dispatch, getState);
expect(result).toEqual({
type: REMOVE_PARAMETER,
payload: { id: 123 },
});
});
});
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment