Merge pull request #2446 from metabase/page-flag-z-index

Be more conservative with our popover z-index. Fixes tutorial page flag.

frontend/src/components/OnClickOutsideWrapper.jsx

@@ -16,6 +16,7 @@ export default class OnClickOutsideWrapper extends ClickOutComponent {
         this.timeout = setTimeout(() => {
             popoverStack.push(this);
             // HACK: set the z-index of the parent element to ensure it's always on top
+            // NOTE: this actually doesn't seem to be working correctly for popovers since PopoverBody creates a stacking context
             ReactDOM.findDOMNode(this).parentNode.style.zIndex = popoverStack.length + 2; // HACK: add 2 to ensure it's in front of main and nav elements
         }, 10);
     }

frontend/src/css/components/popover.css

@@ -6,7 +6,7 @@
 .PopoverContainer {
 	pointer-events: none;
 	position: absolute;
-	z-index: 10000000000000; /* above all the things */
+	z-index: 4;
 }
 
 .PopoverBody {