Skip to content
Snippets Groups Projects
Unverified Commit 02ac6302 authored by Paul Rosenzweig's avatar Paul Rosenzweig Committed by GitHub
Browse files

use null for schema-less db schema name rather than "" (#12299)

parent 86b7d868
No related branches found
No related tags found
No related merge requests found
...@@ -31,7 +31,7 @@ const getRoutes = store => ( ...@@ -31,7 +31,7 @@ const getRoutes = store => (
</Route> </Route>
{/* TABLES NO SCHEMA */} {/* TABLES NO SCHEMA */}
{/* NOTE: this route is to support null schemas, inject the empty string as the schemaName */} {/* NOTE: this route is to support null schemas */}
<Route <Route
path=":databaseId/tables" path=":databaseId/tables"
component={( component={(
...@@ -39,7 +39,7 @@ const getRoutes = store => ( ...@@ -39,7 +39,7 @@ const getRoutes = store => (
) => ( ) => (
<TablesPermissionsApp <TablesPermissionsApp
{...props} {...props}
params={{ ...props.params, schemaName: "" }} params={{ ...props.params, schemaName: null }}
/> />
)} )}
> >
......
...@@ -662,7 +662,7 @@ export const getDatabasesPermissionsGrid = createSelector( ...@@ -662,7 +662,7 @@ export const getDatabasesPermissionsGrid = createSelector(
}, },
name: database.name, name: database.name,
link: link:
schemas.length === 0 || (schemas.length === 1 && schemas[0] === "") schemas.length === 0 || (schemas.length === 1 && schemas[0] == null)
? { ? {
name: t`View tables`, name: t`View tables`,
url: `/admin/permissions/databases/${database.id}/tables`, url: `/admin/permissions/databases/${database.id}/tables`,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment