Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
0398dae6
Unverified
Commit
0398dae6
authored
6 years ago
by
Kyle Doherty
Committed by
GitHub
6 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Overworld title fixes (#8134)
* fix spacing / style of overworld headings * fix badge spacing
parent
9b9fbc11
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
frontend/src/metabase/components/Header.jsx
+2
-2
2 additions, 2 deletions
frontend/src/metabase/components/Header.jsx
frontend/src/metabase/containers/Overworld.jsx
+20
-14
20 additions, 14 deletions
frontend/src/metabase/containers/Overworld.jsx
with
22 additions
and
16 deletions
frontend/src/metabase/components/Header.jsx
+
2
−
2
View file @
0398dae6
...
...
@@ -156,8 +156,8 @@ export default class Header extends Component {
}
ref
=
"header"
>
<
div
className
=
"Entity py3
mb1
"
>
{
titleAndDescription
}
<
div
className
=
"Entity py3"
>
<
span
className
=
"inline-block mb1"
>
{
titleAndDescription
}
</
span
>
{
attribution
}
{
!
this
.
props
.
isEditingInfo
&&
(
<
CollectionBadge
collectionId
=
{
item
.
collection_id
}
/>
...
...
This diff is collapsed.
Click to expand it.
frontend/src/metabase/containers/Overworld.jsx
+
20
−
14
View file @
0398dae6
...
...
@@ -79,10 +79,9 @@ class Overworld extends React.Component {
{
({
candidates
,
sampleCandidates
,
isSample
})
=>
{
return
(
<
Box
mx
=
{
PAGE_PADDING
}
mt
=
{
2
}
>
<
Box
mb
=
{
1
}
>
<
h4
>
{
t
`Not sure where to start? Try these x-rays based on your data.`
}
</
h4
>
</
Box
>
<
SectionHeading
>
{
t
`Not sure where to start? Try these x-rays based on your data.`
}
</
SectionHeading
>
<
Card
px
=
{
3
}
pb
=
{
1
}
>
<
ExplorePane
candidates
=
{
candidates
}
...
...
@@ -105,10 +104,8 @@ class Overworld extends React.Component {
}
return
(
<
Box
px
=
{
PAGE_PADDING
}
>
<
Box
mt
=
{
3
}
mb
=
{
1
}
>
<
h4
>
{
t
`Start here`
}
</
h4
>
</
Box
>
<
Box
px
=
{
PAGE_PADDING
}
mt
=
{
2
}
>
<
SectionHeading
>
{
t
`Start here`
}
</
SectionHeading
>
<
Grid
>
{
pinnedDashboards
.
map
(
pin
=>
{
return
(
...
...
@@ -142,10 +139,8 @@ class Overworld extends React.Component {
</
CollectionItemsLoader
>
<
Box
px
=
{
PAGE_PADDING
}
my
=
{
3
}
>
<
Box
mb
=
{
2
}
>
<
h4
>
{
t
`Our analytics`
}
</
h4
>
</
Box
>
<
Card
p
=
{
[
1
,
2
]
}
>
<
SectionHeading
>
{
t
`Our analytics`
}
</
SectionHeading
>
<
Card
p
=
{
[
1
,
2
]
}
mt
=
{
2
}
>
{
this
.
props
.
collections
.
filter
(
c
=>
c
.
id
!==
user
.
personal_collection_id
,
).
length
>
0
?
(
...
...
@@ -183,8 +178,8 @@ class Overworld extends React.Component {
</
Box
>
<
Box
pt
=
{
2
}
px
=
{
PAGE_PADDING
}
>
<
h4
>
{
t
`Our data`
}
</
h4
>
<
Box
mt
=
{
2
}
mb
=
{
4
}
>
<
SectionHeading
>
{
t
`Our data`
}
</
SectionHeading
>
<
Box
mb
=
{
4
}
>
<
DatabaseListLoader
>
{
({
databases
})
=>
{
return
(
...
...
@@ -218,4 +213,15 @@ class Overworld extends React.Component {
}
}
const
SectionHeading
=
({
children
})
=>
(
<
Box
mb
=
{
1
}
>
<
h5
className
=
"text-uppercase"
style
=
{
{
color
:
colors
[
"
text-medium
"
],
fontWeight
:
900
}
}
>
{
children
}
</
h5
>
</
Box
>
);
export
default
Overworld
;
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment