Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
03cc465d
Commit
03cc465d
authored
8 years ago
by
Sameer Al-Sakran
Committed by
GitHub
8 years ago
Browse files
Options
Downloads
Plain Diff
Merge pull request #4076 from metabase/fix-ga-weekYear
Fix GA driver handling of 'week' unit
parents
e550b521
6e538ae3
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/metabase/driver/googleanalytics.clj
+1
-1
1 addition, 1 deletion
src/metabase/driver/googleanalytics.clj
src/metabase/driver/googleanalytics/query_processor.clj
+12
-12
12 additions, 12 deletions
src/metabase/driver/googleanalytics/query_processor.clj
with
13 additions
and
13 deletions
src/metabase/driver/googleanalytics.clj
+
1
−
1
View file @
03cc465d
...
...
@@ -82,7 +82,7 @@
"ga:hour"
"ga:dayOfWeek"
"ga:day"
"ga:
year
Week"
"ga:
isoYearIso
Week"
"ga:week"
"ga:yearMonth"
"ga:month"
...
...
This diff is collapsed.
Click to expand it.
src/metabase/driver/googleanalytics/query_processor.clj
+
12
−
12
View file @
03cc465d
...
...
@@ -86,7 +86,7 @@
:day
"ga:date"
:day-of-week
"ga:dayOfWeek"
:day-of-month
"ga:day"
:week
"ga:
year
Week"
:week
"ga:
isoYearIso
Week"
:week-of-year
"ga:week"
:month
"ga:yearMonth"
:month-of-year
"ga:month"
...
...
@@ -208,17 +208,17 @@
(
edn/read-string
(
s/replace
s
#
"^0+(.+)$"
"$1"
)))
(
def
^
:private
ga-dimension->date-format-fn
{
"ga:minute"
parse-number
"ga:dateHour"
(
partial
u/parse-date
"yyyyMMddHH"
)
"ga:hour"
parse-number
"ga:date"
(
partial
u/parse-date
"yyyyMMdd"
)
"ga:dayOfWeek"
(
comp
inc
parse-number
)
"ga:day"
parse-number
"ga:
year
Week"
(
partial
u/parse-date
"YYYYww"
)
"ga:week"
parse-number
"ga:yearMonth"
(
partial
u/parse-date
"yyyyMM"
)
"ga:month"
parse-number
"ga:year"
parse-number
})
{
"ga:minute"
parse-number
"ga:dateHour"
(
partial
u/parse-date
"yyyyMMddHH"
)
"ga:hour"
parse-number
"ga:date"
(
partial
u/parse-date
"yyyyMMdd"
)
"ga:dayOfWeek"
(
comp
inc
parse-number
)
"ga:day"
parse-number
"ga:
isoYearIso
Week"
(
partial
u/parse-date
"YYYYww"
)
"ga:week"
parse-number
"ga:yearMonth"
(
partial
u/parse-date
"yyyyMM"
)
"ga:month"
parse-number
"ga:year"
parse-number
})
(
defn-
header->column
[
^
GaData$ColumnHeaders
header
]
(
let
[
date-parser
(
ga-dimension->date-format-fn
(
.getName
header
))]
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment