Skip to content
Snippets Groups Projects
Commit 03cc465d authored by Sameer Al-Sakran's avatar Sameer Al-Sakran Committed by GitHub
Browse files

Merge pull request #4076 from metabase/fix-ga-weekYear

Fix GA driver handling of 'week' unit
parents e550b521 6e538ae3
No related branches found
No related tags found
No related merge requests found
......@@ -82,7 +82,7 @@
"ga:hour"
"ga:dayOfWeek"
"ga:day"
"ga:yearWeek"
"ga:isoYearIsoWeek"
"ga:week"
"ga:yearMonth"
"ga:month"
......
......@@ -86,7 +86,7 @@
:day "ga:date"
:day-of-week "ga:dayOfWeek"
:day-of-month "ga:day"
:week "ga:yearWeek"
:week "ga:isoYearIsoWeek"
:week-of-year "ga:week"
:month "ga:yearMonth"
:month-of-year "ga:month"
......@@ -208,17 +208,17 @@
(edn/read-string (s/replace s #"^0+(.+)$" "$1")))
(def ^:private ga-dimension->date-format-fn
{"ga:minute" parse-number
"ga:dateHour" (partial u/parse-date "yyyyMMddHH")
"ga:hour" parse-number
"ga:date" (partial u/parse-date "yyyyMMdd")
"ga:dayOfWeek" (comp inc parse-number)
"ga:day" parse-number
"ga:yearWeek" (partial u/parse-date "YYYYww")
"ga:week" parse-number
"ga:yearMonth" (partial u/parse-date "yyyyMM")
"ga:month" parse-number
"ga:year" parse-number})
{"ga:minute" parse-number
"ga:dateHour" (partial u/parse-date "yyyyMMddHH")
"ga:hour" parse-number
"ga:date" (partial u/parse-date "yyyyMMdd")
"ga:dayOfWeek" (comp inc parse-number)
"ga:day" parse-number
"ga:isoYearIsoWeek" (partial u/parse-date "YYYYww")
"ga:week" parse-number
"ga:yearMonth" (partial u/parse-date "yyyyMM")
"ga:month" parse-number
"ga:year" parse-number})
(defn- header->column [^GaData$ColumnHeaders header]
(let [date-parser (ga-dimension->date-format-fn (.getName header))]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment