-
- Downloads
Secrets 
PR 6 - Update Oracle properties (#18320)

* Add SSL keystore and truststore secret properties to Oracle driver YAML files
Update Oracle driver to set keystore and truststore connection options from secret values
Adding new `select-keys-sequentially` helper function for dealing with assertions on transformed conn props
Add new function to the secret namespace to return a lighter weight "secret map", and remove that functionality from the `handle-db-details-secret-prop!`, so that it can be reused from connection testing
Modifying CircleCI to set the corresponding truststore secret conn prop vars instead of JVM-level truststore settings, as the test had been doing previously
Expand Oracle test connection details to incorporate all SSL related properties, and also make it a function instead of delayed def (so changes can be picked up later)
Misc. fixes in Oracle driver YAML files
Update `exception-classes-not-to-retry` to include SSLHandshakeException
Fix misc issues in secret and database model code
Update CircleCI config to use correct secret based env var keys and values
Add *database-name-override* dynamic var in `metabase.test.data.interface` to allow for DB name overriding
Fix up ssl connectivity test so all parts pass successfully
Get rid of crazy with-redefs to swap in the existing test-data's schema, and instead, just dropping the DB if it was created under a different schema (similar to what H2 does)
Co-authored-by:
Gustavo Saiani <gustavo@poe.ma>
Showing
- .circleci/config.yml 6 additions, 3 deletions.circleci/config.yml
- frontend/src/metabase/components/form/widgets/FormInputWidget.jsx 3 additions, 0 deletions.../src/metabase/components/form/widgets/FormInputWidget.jsx
- frontend/src/metabase/components/form/widgets/FormTextFileWidget.jsx 19 additions, 7 deletions...c/metabase/components/form/widgets/FormTextFileWidget.jsx
- modules/drivers/oracle/resources-ee/metabase-plugin.yaml 38 additions, 0 deletionsmodules/drivers/oracle/resources-ee/metabase-plugin.yaml
- modules/drivers/oracle/resources/metabase-plugin.yaml 38 additions, 0 deletionsmodules/drivers/oracle/resources/metabase-plugin.yaml
- modules/drivers/oracle/src/metabase/driver/oracle.clj 41 additions, 10 deletionsmodules/drivers/oracle/src/metabase/driver/oracle.clj
- modules/drivers/oracle/test/metabase/driver/oracle_test.clj 90 additions, 4 deletionsmodules/drivers/oracle/test/metabase/driver/oracle_test.clj
- modules/drivers/oracle/test/metabase/test/data/oracle.clj 68 additions, 12 deletionsmodules/drivers/oracle/test/metabase/test/data/oracle.clj
- src/metabase/models/database.clj 12 additions, 21 deletionssrc/metabase/models/database.clj
- src/metabase/models/secret.clj 50 additions, 6 deletionssrc/metabase/models/secret.clj
- src/metabase/sync/util.clj 2 additions, 1 deletionsrc/metabase/sync/util.clj
- test/metabase/driver/util_test.clj 42 additions, 34 deletionstest/metabase/driver/util_test.clj
- test/metabase/test.clj 1 addition, 0 deletionstest/metabase/test.clj
- test/metabase/test/data/interface.clj 15 additions, 1 deletiontest/metabase/test/data/interface.clj
- test/metabase/test/util.clj 33 additions, 0 deletionstest/metabase/test/util.clj
Loading
Please register or sign in to comment