Skip to content
Snippets Groups Projects
Unverified Commit 052fae56 authored by dpsutton's avatar dpsutton Committed by GitHub
Browse files

Handle infinity/-infinity (fixes #12761) [ci all] (#13539)

parent 2670f6c8
No related branches found
No related tags found
No related merge requests found
......@@ -51,9 +51,12 @@
OffsetDateTime
(format-value [t, ^ZoneId timezone-id]
(t/format :iso-offset-date-time
(let [rules (.getRules timezone-id)
offset (.getOffset rules (t/instant t))]
(t/with-offset-same-instant t offset))))
(if (or (= t OffsetDateTime/MAX)
(= t OffsetDateTime/MIN))
t
(let [rules (.getRules timezone-id)
offset (.getOffset rules (t/instant t))]
(t/with-offset-same-instant t offset)))))
ZonedDateTime
(format-value [t timezone-id]
......
......@@ -160,7 +160,10 @@
(mt/with-clock (t/mock-clock (t/instant clock-instant) clock-zone)
(is (= expected
(format-rows/format-value t (t/zone-id zone)))
(format "format %s '%s' with results timezone ID '%s'" (.getName (class t)) t zone)))))))
(format "format %s '%s' with results timezone ID '%s'" (.getName (class t)) t zone))))))
(testing "can handle infinity dates (#12761)"
(is (format-rows/format-value java.time.OffsetDateTime/MAX (t/zone-id "UTC")))
(is (format-rows/format-value java.time.OffsetDateTime/MIN (t/zone-id "UTC")))))
(deftest results-timezone-test
(testing "Make sure ISO-8601 timestamps are written correctly based on the report-timezone"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment