Remove more metabse settings (#47510)

* remove more metabse settings

* fix missing update for latest version check

* test updates

* fix setting selectors

enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.jsx

@@ -9,7 +9,7 @@ import SettingHeader from "metabase/admin/settings/components/SettingHeader";
 import GroupMappingsWidget from "metabase/admin/settings/containers/GroupMappingsWidget";
 import { updateSamlSettings } from "metabase/admin/settings/settings";
 import { settingToFormField } from "metabase/admin/settings/utils";
-import { useDocsUrl } from "metabase/common/hooks";
+import { useDocsUrl, useSetting } from "metabase/common/hooks";
 import Breadcrumbs from "metabase/components/Breadcrumbs";
 import ExternalLink from "metabase/core/components/ExternalLink";
 import CS from "metabase/css/core/index.css";
@@ -23,7 +23,6 @@ import {
   FormTextInput,
   FormTextarea,
 } from "metabase/forms";
-import MetabaseSettings from "metabase/lib/settings";
 import { Stack } from "metabase/ui";
 
 import {
@@ -72,11 +71,13 @@ const SettingsSAMLForm = ({ elements = [], settingValues = {}, onSubmit }) => {
     "people-and-groups/authenticating-with-saml",
   );
 
+  const siteUrl = useSetting("site-url");
+
   return (
     <FormProvider
       initialValues={{
         ...attributeValues,
-        [FAKE_ACS_URL_KEY]: getAcsCustomerUrl(),
+        [FAKE_ACS_URL_KEY]: `${siteUrl}/auth/sso`,
       }}
       onSubmit={handleSubmit}
       enableReinitialize
@@ -271,10 +272,6 @@ const getAttributeValues = (values, defaults) => {
   );
 };
 
-const getAcsCustomerUrl = () => {
-  return `${MetabaseSettings.get("site-url")}/auth/sso`;
-};
-
 SettingsSAMLForm.propTypes = propTypes;
 
 const mapDispatchToProps = {

enterprise/frontend/src/metabase-enterprise/plugins.js

-import MetabaseSettings from "metabase/lib/settings";
 import { PLUGIN_IS_EE_BUILD } from "metabase/plugins";
 
 // SETTINGS OVERRIDES:
-
-// NOTE: temporarily use "latest" for Enterprise Edition docs
-MetabaseSettings.docsTag = () => "latest";
 PLUGIN_IS_EE_BUILD.isEEBuild = () => true;
 
 import "./shared";

frontend/lint/eslint-rules/no-unconditional-metabase-links-render.js

@@ -4,12 +4,11 @@
 //
 // The following cases are considered errors:
 //
-// 1. MetabaseSettings.learnUrl(string)
-// 2. useDocsUrl hook
-// 3. getDocsUrl selector from "metabase/selectors/settings"
-// 4. getLearnUrl selector from "metabase/selectors/settings"
-// 5. inline string "metabase.com/docs/"
-// 6. inline string "metabase.com/learn/"
+// 1. useDocsUrl hook
+// 2. getDocsUrl selector from "metabase/selectors/settings"
+// 3. getLearnUrl selector from "metabase/selectors/settings"
+// 4. inline string "metabase.com/docs/"
+// 5. inline string "metabase.com/learn/"
 //
 // If a link shouldn't be rendered conditionally e.g. it's only show for admins, or is rendered inside admin settings, you need to disable the rule with a reason.
 // e.g. "// eslint-disable-next-line no-unconditional-metabase-links-render -- This link only shows for admins."
@@ -50,7 +49,6 @@ module.exports = {
   },
 
   create(context) {
-    let metabaseSettings;
     let isGetDocsUrlSelectorImported = false;
     let isGetLearnUrlSelectorImported = false;
     let isGetShowMetabaseLinksSelectorImported = false;
@@ -89,17 +87,6 @@ module.exports = {
 
     return {
       ImportDeclaration(node) {
-        if (
-          getImportedModuleNode(node, {
-            isDefault: true,
-            source: "metabase/lib/settings",
-          })
-        ) {
-          metabaseSettings = getImportedModuleNode(node, {
-            isDefault: true,
-            source: "metabase/lib/settings",
-          });
-        }
         if (
           getImportedModuleNode(node, {
             named: "getDocsUrl",
@@ -171,20 +158,6 @@ module.exports = {
             message: ERROR_MESSAGE,
           });
         }
-
-        // call `MetabaseSettings.learnUrl`
-        if (
-          metabaseSettings?.references.some(
-            reference => reference.identifier === node?.callee?.object,
-          ) &&
-          !isGetShowMetabaseLinksSelectorImported &&
-          ["learnUrl", "docsUrl"].includes(node?.callee?.property?.name)
-        ) {
-          context.report({
-            node,
-            message: ERROR_MESSAGE,
-          });
-        }
       },
       Literal(node) {
         if (typeof node.value !== "string") {

frontend/lint/tests/no-unconditional-metabase-links-render.unit.spec.js

@@ -19,20 +19,6 @@ const ruleTester = new RuleTester({
 const VALID_CASES = [
   {
     code: `
-import MetabaseSettings from "metabase/lib/settings";
-import { getShowMetabaseLinks } from "metabase/selectors/whitelabel";
-
-const docsUrl = MetabaseSettings.docsUrl("permissions/data")`,
-  },
-  {
-    code: `
-import MetabaseSettings from "metabase/lib/settings";
-import { getShowMetabaseLinks } from "metabase/selectors/whitelabel";
-
-const docsUrl = MetabaseSettings.learnUrl("permissions/data")`,
-  },
-  {
-    code: `
 import { useSelector } from "metabase/lib/redux";
 import { getDocsUrl } from "metabase/selectors/settings";
 import { getShowMetabaseLinks } from "metabase/selectors/whitelabel";
@@ -97,33 +83,6 @@ const { url } = useDocsUrl("permissions/data");`,
   },
 ];
 const INVALID_CASES = [
-  {
-    name: 'Detect any name of the default import of "metabase/lib/settings"',
-    code: `
-import Settings from "metabase/lib/settings";
-
-const docsUrl = Settings.docsUrl("permissions/data")`,
-    error:
-      /Metabase links must be rendered conditionally\.(.|\n)*Please import `getShowMetabaseLinks`(.|\n)*Or add comment to indicate the reason why this rule needs to be disabled/,
-  },
-  {
-    name: "Detect MetabaseSettings.docsUrl()",
-    code: `
-import MetabaseSettings from "metabase/lib/settings";
-
-const docsUrl = MetabaseSettings.docsUrl("permissions/data")`,
-    error:
-      /Metabase links must be rendered conditionally\.(.|\n)*Please import `getShowMetabaseLinks`(.|\n)*Or add comment to indicate the reason why this rule needs to be disabled/,
-  },
-  {
-    name: "Detect MetabaseSettings.learn()",
-    code: `
-import MetabaseSettings from "metabase/lib/settings";
-
-const docsUrl = MetabaseSettings.learnUrl("permissions/data")`,
-    error:
-      /Metabase links must be rendered conditionally\.(.|\n)*Please import `getShowMetabaseLinks`(.|\n)*Or add comment to indicate the reason why this rule needs to be disabled/,
-  },
   {
     name: "Detect getDocsUrl()",
     code: `

frontend/src/metabase-types/api/mocks/settings.ts

@@ -200,7 +200,7 @@ export const createMockSettings = (
   "openai-organization": null,
   "openai-model": null,
   "openai-available-models": [],
-  "other-sso-enabled?": null,
+  "other-sso-enabled?": false,
   "password-complexity": { total: 6, digit: 1 },
   "persisted-models-enabled": false,
   "persisted-model-refresh-cron-schedule": "0 0 0/6 * * ? *",

frontend/src/metabase-types/api/settings.ts

@@ -246,6 +246,7 @@ interface AdminSettings {
   "premium-embedding-token": string | null;
   "saml-configured"?: boolean;
   "saml-enabled"?: boolean;
+  "other-sso-enabled?"?: boolean; // yes the question mark is in the variable name
   "show-database-syncing-modal": boolean;
   "token-status": TokenStatus | null;
   "version-info": VersionInfo | null;

frontend/src/metabase/admin/app/actions.ts

 import { updateSetting } from "metabase/admin/settings/settings";
 import { createAsyncThunk } from "metabase/lib/redux";
-import Settings from "metabase/lib/settings";
+
+import { getCurrentVersion } from "../settings/selectors";
 
 export const disableNotice = createAsyncThunk(
   "metabase/admin/app/DISABLE_NOTICE",
-  async (_, { dispatch }) => {
+  async (_, { getState, dispatch }) => {
     const setting = {
       key: "deprecation-notice-version",
-      value: Settings.currentVersion(),
+      value: getCurrentVersion(getState()),
     };
     await dispatch(updateSetting(setting));
   },

frontend/src/metabase/admin/databases/components/DatabaseEditApp/Sidebar/ModelCachingControl/ModelCachingControl.tsx

@@ -5,13 +5,12 @@ import {
   PERSIST_DATABASE,
   UNPERSIST_DATABASE,
 } from "metabase/admin/databases/database";
-import { useDocsUrl } from "metabase/common/hooks";
+import { useDocsUrl, useSetting } from "metabase/common/hooks";
 import ActionButton from "metabase/components/ActionButton";
 import TippyPopover from "metabase/components/Popover/TippyPopover";
 import ExternalLink from "metabase/core/components/ExternalLink";
 import ButtonsS from "metabase/css/components/buttons.module.css";
 import { useDispatch } from "metabase/lib/redux";
-import MetabaseSettings from "metabase/lib/settings";
 import { MetabaseApi } from "metabase/services";
 import type Database from "metabase-lib/v1/metadata/Database";
 import { getModelCacheSchemaName } from "metabase-lib/v1/metadata/utils/models";
@@ -66,8 +65,8 @@ function ModelCachingControl({ database }: Props) {
     ? t`Turn model persistence off`
     : t`Turn model persistence on`;
 
-  const siteUUID = MetabaseSettings.get("site-uuid") || "";
-  const cacheSchemaName = getModelCacheSchemaName(databaseId, siteUUID);
+  const siteUUID = useSetting("site-uuid");
+  const cacheSchemaName = getModelCacheSchemaName(databaseId, siteUUID || "");
 
   const handleCachingChange = async () => {
     setError(null);

frontend/src/metabase/admin/databases/containers/DatabaseListApp.jsx

@@ -3,9 +3,9 @@ import _ from "underscore";
 
 import LoadingAndGenericErrorWrapper from "metabase/components/LoadingAndGenericErrorWrapper";
 import Database from "metabase/entities/databases";
-import MetabaseSettings from "metabase/lib/settings";
 import { isSyncInProgress } from "metabase/lib/syncing";
 import { PLUGIN_FEATURE_LEVEL_PERMISSIONS } from "metabase/plugins";
+import { getSetting } from "metabase/selectors/settings";
 import { getUserIsAdmin } from "metabase/selectors/user";
 
 import DatabaseList from "../components/DatabaseList";
@@ -41,8 +41,8 @@ const mapStateToProps = (state, props) => ({
 
   created: props.location.query.created,
   createdDbId: props.location.query.createdDbId,
-  engines: MetabaseSettings.get("engines"),
-  showSyncingModal: MetabaseSettings.get("show-database-syncing-modal"),
+  engines: getSetting(state, "engines"),
+  showSyncingModal: getSetting(state, "show-database-syncing-modal"),
 
   deletes: getDeletes(state),
   deletionError: getDeletionError(state),

frontend/src/metabase/admin/datamodel/containers/DataModelApp/ModelEducationalModal.jsx

@@ -6,7 +6,7 @@ import Modal from "metabase/components/Modal";
 import ModalContent from "metabase/components/ModalContent";
 import ButtonsS from "metabase/css/components/buttons.module.css";
 import CS from "metabase/css/core/index.css";
-import MetabaseSettings from "metabase/lib/settings";
+import { getLearnUrl } from "metabase/selectors/settings";
 
 import {
   ButtonLink,
@@ -20,7 +20,7 @@ ModelEducationalModal.propTypes = {
   onClose: PropTypes.func.isRequired,
 };
 
-const EDUCATION_URL = MetabaseSettings.learnUrl("getting-started/models");
+const EDUCATION_URL = getLearnUrl("getting-started/models");
 
 export function ModelEducationalModal({ isOpen, onClose }) {
   return (

frontend/src/metabase/admin/people/containers/UserSuccessModal.jsx

@@ -12,7 +12,7 @@ import Button from "metabase/core/components/Button";
 import Link from "metabase/core/components/Link";
 import CS from "metabase/css/core/index.css";
 import Users from "metabase/entities/users";
-import MetabaseSettings from "metabase/lib/settings";
+import { getSetting, isSsoEnabled } from "metabase/selectors/settings";
 
 import { clearTemporaryPassword } from "../people";
 import { getUserTemporaryPassword } from "../selectors";
@@ -25,10 +25,14 @@ class UserSuccessModal extends Component {
   }
 
   render() {
-    const { onClose, user, temporaryPassword } = this.props;
-    const isSsoEnabled =
-      MetabaseSettings.isSsoEnabled() &&
-      !MetabaseSettings.isPasswordLoginEnabled();
+    const {
+      onClose,
+      user,
+      temporaryPassword,
+      isSsoEnabled,
+      isPasswordLoginEnabled,
+    } = this.props;
+    const ssoEnabled = isSsoEnabled && !isPasswordLoginEnabled;
     return (
       <ModalContent
         title={t`${user.common_name} has been added`}
@@ -38,7 +42,7 @@ class UserSuccessModal extends Component {
         {temporaryPassword ? (
           <PasswordSuccess user={user} temporaryPassword={temporaryPassword} />
         ) : (
-          <EmailSuccess isSsoEnabled={isSsoEnabled} user={user} />
+          <EmailSuccess isSsoEnabled={ssoEnabled} user={user} />
         )}
       </ModalContent>
     );
@@ -86,7 +90,6 @@ const PasswordSuccess = ({ user, temporaryPassword }) => (
     </div>
   </div>
 );
-
 export default _.compose(
   Users.load({
     id: (state, props) => props.params.userId,
@@ -96,6 +99,8 @@ export default _.compose(
       temporaryPassword: getUserTemporaryPassword(state, {
         userId: props.params.userId,
       }),
+      isSsoEnabled: isSsoEnabled(state),
+      isPasswordLoginEnabled: getSetting(state, "enable-password-login"),
     }),
     {
       onClose: () => push("/admin/people"),

frontend/src/metabase/admin/settings/components/SettingsUpdatesForm/SettingsUpdatesForm.jsx

@@ -2,8 +2,8 @@ import cx from "classnames";
 import PropTypes from "prop-types";
 
 import { UpsellHostingUpdates } from "metabase/admin/upsells";
+import { useSetting } from "metabase/common/hooks";
 import CS from "metabase/css/core/index.css";
-import MetabaseSettings from "metabase/lib/settings";
 import { Flex } from "metabase/ui";
 
 import { SettingsSetting } from "../SettingsSetting";
@@ -18,16 +18,17 @@ export default function SettingsUpdatesForm({ elements, updateSetting }) {
       autoFocus={index === 0}
     />
   ));
+  const isHosted = useSetting("is-hosted");
 
   return (
     <Flex justify="space-between">
       <div style={{ width: "585px" }}>
-        {!MetabaseSettings.isHosted() && <ul>{settings}</ul>}
+        {!isHosted && <ul>{settings}</ul>}
 
         <div className={CS.px2}>
           <div
             className={cx(CS.pt3, {
-              [CS.borderTop]: !MetabaseSettings.isHosted(),
+              [CS.borderTop]: !isHosted,
             })}
           >
             <VersionUpdateNotice />

frontend/src/metabase/admin/settings/components/SettingsUpdatesForm/SettingsUpdatesForm.unit.spec.js

@@ -51,17 +51,17 @@ function setup({
 }
 
 describe("SettingsUpdatesForm", () => {
-  it("shows custom message for Cloud installations", () => {
+  it("shows custom message for Cloud installations", async () => {
     setup({ isHosted: true });
     expect(
-      screen.getByText(/Metabase Cloud keeps your instance up-to-date/),
+      await screen.findByText(/Metabase Cloud keeps your instance up-to-date/),
     ).toBeInTheDocument();
   });
 
-  it("shows correct message when latest version is installed", () => {
+  it("shows correct message when latest version is installed", async () => {
     setup({ currentVersion: "v1.0.0", latestVersion: "v1.0.0" });
     expect(
-      screen.getByText(/You're running Metabase 1.0.0/),
+      await screen.findByText(/You're running Metabase 1.0.0/),
     ).toBeInTheDocument();
   });
 

frontend/src/metabase/admin/settings/components/SettingsUpdatesForm/VersionUpdateNotice/VersionUpdateNotice.jsx

@@ -2,10 +2,17 @@ import cx from "classnames";
 import PropTypes from "prop-types";
 import { t } from "ttag";
 
+import {
+  getCurrentVersion,
+  getLatestVersion,
+} from "metabase/admin/settings/selectors";
 import ExternalLink from "metabase/core/components/ExternalLink";
 import ButtonsS from "metabase/css/components/buttons.module.css";
 import CS from "metabase/css/core/index.css";
+import { useSelector } from "metabase/lib/redux";
 import MetabaseSettings from "metabase/lib/settings";
+import { newVersionAvailable, versionIsLatest } from "metabase/lib/utils";
+import { getIsHosted } from "metabase/setup/selectors";
 
 import {
   NewVersionContainer,
@@ -13,18 +20,22 @@ import {
 } from "./VersionUpdateNotice.styled";
 
 export default function VersionUpdateNotice() {
-  const currentVersion = formatVersion(MetabaseSettings.currentVersion());
+  const currentVersion = useSelector(getCurrentVersion);
+  const latestVersion = useSelector(getLatestVersion);
+  const isHosted = useSelector(getIsHosted);
 
-  if (MetabaseSettings.isHosted()) {
+  if (isHosted) {
     return <CloudCustomers currentVersion={currentVersion} />;
   }
 
-  if (MetabaseSettings.versionIsLatest()) {
-    return <OnLatestVersion currentVersion={currentVersion} />;
+  const displayVersion = formatVersion(currentVersion);
+
+  if (versionIsLatest({ currentVersion, latestVersion })) {
+    return <OnLatestVersion currentVersion={displayVersion} />;
   }
 
-  if (MetabaseSettings.newVersionAvailable()) {
-    return <NewVersionAvailable currentVersion={currentVersion} />;
+  if (newVersionAvailable({ currentVersion, latestVersion })) {
+    return <NewVersionAvailable currentVersion={displayVersion} />;
   }
 
   return <div>{t`No successful checks yet.`}</div>;

frontend/src/metabase/admin/settings/selectors.js

@@ -6,6 +6,7 @@ import { SMTPConnectionForm } from "metabase/admin/settings/components/Email/SMT
 import Breadcrumbs from "metabase/components/Breadcrumbs";
 import { DashboardSelector } from "metabase/components/DashboardSelector";
 import MetabaseSettings from "metabase/lib/settings";
+import { newVersionAvailable } from "metabase/lib/utils";
 import {
   PLUGIN_ADMIN_SETTINGS_AUTH_TABS,
   PLUGIN_ADMIN_SETTINGS_UPDATES,
@@ -620,9 +621,30 @@ export const getSettingValues = createSelector(getSettings, settings => {
   return settingValues;
 });
 
-export const getNewVersionAvailable = createSelector(getSettings, settings => {
-  return MetabaseSettings.newVersionAvailable(settings);
-});
+export const getCurrentVersion = createSelector(
+  getDerivedSettingValues,
+  settings => {
+    return settings.version?.tag;
+  },
+);
+
+export const getLatestVersion = createSelector(
+  getDerivedSettingValues,
+  settings => {
+    return settings["version-info"]?.latest?.version;
+  },
+);
+
+export const getNewVersionAvailable = createSelector(
+  getCurrentVersion,
+  getLatestVersion,
+  (currentVersion, latestVersion) => {
+    return newVersionAvailable({
+      currentVersion,
+      latestVersion,
+    });
+  },
+);
 
 export const getSections = createSelector(
   getSettings,

frontend/src/metabase/home/components/HomeHelpCard/HomeHelpCard.tsx

@@ -2,7 +2,7 @@ import { t } from "ttag";
 
 import { useUniqueId } from "metabase/hooks/use-unique-id";
 import { useSelector } from "metabase/lib/redux";
-import MetabaseSettings from "metabase/lib/settings";
+import { getLearnUrl } from "metabase/selectors/settings";
 import {
   getApplicationName,
   getShowMetabaseLinks,
@@ -20,7 +20,7 @@ export const HomeHelpCard = (): JSX.Element | null => {
   }
 
   return (
-    <CardRoot href={MetabaseSettings.learnUrl()} aria-labelledby={cardTitleId}>
+    <CardRoot href={getLearnUrl()} aria-labelledby={cardTitleId}>
       <CardIcon name="reference" />
       <CardTitle id={cardTitleId}>{t`${applicationName} tips`}</CardTitle>
     </CardRoot>

frontend/src/metabase/lib/settings.ts

@@ -3,7 +3,7 @@ import { msgid, ngettext, t } from "ttag";
 import _ from "underscore";
 
 import { parseTimestamp } from "metabase/lib/time";
-import { compareVersions, numberToWord } from "metabase/lib/utils";
+import { numberToWord } from "metabase/lib/utils";
 import type {
   PasswordComplexity,
   SettingKey,
@@ -145,13 +145,6 @@ class MetabaseSettings {
     return this.get("cloud-gateway-ips") || [];
   }
 
-  /**
-   * @deprecated use getSetting(state, "has-user-setup")
-   */
-  hasUserSetup() {
-    return this.get("has-user-setup");
-  }
-
   /**
    * @deprecated use getSetting(state, "hide-embed-branding?")
    */
@@ -187,17 +180,6 @@ class MetabaseSettings {
     return this.get("other-sso-enabled?");
   }
 
-  /**
-   * @deprecated use getSetting(state, ...)
-   */
-  isSsoEnabled() {
-    return (
-      this.isLdapEnabled() ||
-      this.isGoogleAuthEnabled() ||
-      this.isOtherSsoEnabled()
-    );
-  }
-
   /**
    * @deprecated use getSetting(state, "enable-password-login")
    */
@@ -273,35 +255,6 @@ class MetabaseSettings {
     }
   }
 
-  /**
-   * @deprecated use getLearnUrl
-   */
-  learnUrl(path = "") {
-    // eslint-disable-next-line no-unconditional-metabase-links-render -- This is the implementation of MetabaseSettings.learnUrl()
-    return `https://www.metabase.com/learn/${path}`;
-  }
-
-  /**
-   * @deprecated use getStoreUrl
-   */
-  storeUrl(path = "") {
-    return `https://store.metabase.com/${path}`;
-  }
-
-  migrateToCloudGuideUrl() {
-    return "https://www.metabase.com/cloud/docs/migrate/guide";
-  }
-
-  newVersionAvailable() {
-    const result = compareVersions(this.currentVersion(), this.latestVersion());
-    return result != null && result < 0;
-  }
-
-  versionIsLatest() {
-    const result = compareVersions(this.currentVersion(), this.latestVersion());
-    return result != null && result >= 0;
-  }
-
   /**
    * @deprecated use getSetting(state, "version-info")
    */

frontend/src/metabase/lib/utils.ts

@@ -138,4 +138,26 @@ export function compareVersions(
   return 0;
 }
 
+export function newVersionAvailable({
+  currentVersion,
+  latestVersion,
+}: {
+  currentVersion: string;
+  latestVersion: string;
+}) {
+  const result = compareVersions(currentVersion, latestVersion);
+  return result != null && result < 0;
+}
+
+export function versionIsLatest({
+  currentVersion,
+  latestVersion,
+}: {
+  currentVersion: string;
+  latestVersion: string;
+}) {
+  const result = compareVersions(currentVersion, latestVersion);
+  return result != null && result >= 0;
+}
+
 export const isEEBuild = () => PLUGIN_IS_EE_BUILD.isEEBuild();

frontend/src/metabase/models/containers/NewModelOptions/NewModelOptions.tsx

@@ -9,12 +9,11 @@ import { Grid } from "metabase/components/Grid";
 import CS from "metabase/css/core/index.css";
 import Databases from "metabase/entities/databases";
 import { useSelector } from "metabase/lib/redux";
-import MetabaseSettings from "metabase/lib/settings";
 import * as Urls from "metabase/lib/urls";
 import NewModelOption from "metabase/models/components/NewModelOption";
 import { NoDatabasesEmptyState } from "metabase/reference/databases/NoDatabasesEmptyState";
 import { getHasDataAccess, getHasNativeWrite } from "metabase/selectors/data";
-import { getSetting } from "metabase/selectors/settings";
+import { getLearnUrl, getSetting } from "metabase/selectors/settings";
 import { getShowMetabaseLinks } from "metabase/selectors/whitelabel";
 
 import {
@@ -23,7 +22,7 @@ import {
   OptionsRoot,
 } from "./NewModelOptions.styled";
 
-const EDUCATIONAL_LINK = MetabaseSettings.learnUrl("data-modeling/models");
+const EDUCATIONAL_LINK = getLearnUrl("data-modeling/models");
 
 interface NewModelOptionsProps {
   location: Location;

frontend/src/metabase/nav/components/PaymentBanner/PaymentBanner.tsx

@@ -3,7 +3,7 @@ import { jt, t } from "ttag";
 import Banner from "metabase/components/Banner";
 import ExternalLink from "metabase/core/components/ExternalLink";
 import CS from "metabase/css/core/index.css";
-import MetabaseSettings from "metabase/lib/settings";
+import { getStoreUrl } from "metabase/selectors/settings";
 import type { TokenStatus } from "metabase-types/api";
 
 interface PaymentBannerProps {
@@ -19,7 +19,7 @@ export const PaymentBanner = ({ isAdmin, tokenStatus }: PaymentBannerProps) => {
           <ExternalLink
             key="payment-past-due"
             className={CS.link}
-            href={MetabaseSettings.storeUrl()}
+            href={getStoreUrl()}
           >
             {t`review your payment settings`}
           </ExternalLink>
@@ -33,7 +33,7 @@ export const PaymentBanner = ({ isAdmin, tokenStatus }: PaymentBannerProps) => {
           <ExternalLink
             key="payment-unpaid"
             className={CS.link}
-            href={MetabaseSettings.storeUrl()}
+            href={getStoreUrl()}
           >
             {t`Review your payment settings`}
           </ExternalLink>