Fix getting started guide endpoint if no metrics are defined

src/metabase/api/getting_started.clj

@@ -33,7 +33,8 @@
      :important_segments       segment-ids
      ;; A map of metric_id -> sequence of important field_ids
      :metric_important_fields  (m/map-vals (partial map :field_id)
-                                           (group-by :metric_id (db/select ['MetricImportantField :field_id :metric_id]
-                                                                 :metric_id [:in metric-ids])))}))
+                                           (group-by :metric_id (when (seq metric-ids)
+                                                                  (db/select ['MetricImportantField :field_id :metric_id]
+                                                                    :metric_id [:in metric-ids]))))}))
 
 (define-routes)

test/metabase/api/getting_started_guide_test.clj

+(ns metabase.api.getting-started-guide-test
+  (:require [expectations :refer :all]
+            [metabase.test.data.users :refer [user->client]]))
+
+;; just make sure the getting started guide endpoint works and returns the correct keys
+(expect
+  #{:metric_important_fields :most_important_dashboard :things_to_know :important_metrics :important_segments :important_tables :contact}
+  (set (keys ((user->client :rasta) :get 200 "getting_started"))))

test/metabase/test/data/users.clj

 (ns metabase.test.data.users
   "Code related to creating / managing fake `Users` for testing purposes."
+  ;; TODO - maybe this namespace should just be `metabase.test.users`.
   (:require [medley.core :as m]
             (metabase [db :as db]
                       [http-client :as http])