Skip to content
Snippets Groups Projects
Unverified Commit 095f1a1a authored by Aleksandr Lesnenko's avatar Aleksandr Lesnenko Committed by GitHub
Browse files

sankey chart visual tests (#49457)


* sankey visual specs, polish

* Update Loki Snapshots

* improve type

---------

Co-authored-by: default avatarMetabase Automation <github-automation@metabase.com>
parent 25bab869
No related branches found
No related tags found
No related merge requests found
Showing
with 43 additions and 18 deletions
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png

81.9 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png

81.9 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Date_Filter_Month_Year.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png

78.5 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png

78.6 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Range.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png

73.3 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png

73.2 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Light_Theme_Date_Filter_Relative.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Dark_Theme_Default.png

18 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Dark_Theme_Default.png

17.8 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Dark_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Dark_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Dark_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Dark_Theme_Default.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Light_Theme_Default.png

17.5 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Light_Theme_Default.png

17.5 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Light_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Light_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Light_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Light_Theme_Default.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Transparent_Theme_Default.png

17.5 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Transparent_Theme_Default.png

17.6 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Transparent_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Transparent_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Transparent_Theme_Default.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Transparent_Theme_Default.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Disconnected_Graphs.png

14.3 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Edge_Labels_Auto.png

31.2 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Edge_Labels_Compact.png

32 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Edge_Labels_Full.png

30.8 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Gray_Edges.png

88.7 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Node_Align_Justify.png

94.6 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Node_Align_Left.png

87.4 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Node_Align_Right.png

87.6 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Target_Color_Edges.png

86.2 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_Unaggregated_Data.png

12.9 KiB

.loki/reference/chrome_laptop_viz_SankeyChart_Sankey_With_Edges_Labels.png

86.5 KiB

......@@ -6,17 +6,11 @@ import ReactDOMServer from "react-dom/server";
import "metabase/lib/dayjs";
import { formatValue } from "metabase/lib/formatting";
import { StaticVisualization } from "metabase/static-viz/components/StaticVisualization";
import { createColorGetter } from "metabase/static-viz/lib/colors";
import {
measureTextEChartsAdapter,
measureTextHeight,
measureTextWidth,
} from "metabase/static-viz/lib/text";
import { createStaticRenderingContext } from "metabase/static-viz/lib/rendering-context";
import { measureTextEChartsAdapter } from "metabase/static-viz/lib/text";
import { extractRemappings } from "metabase/visualizations";
import { extendCardWithDashcardSettings } from "metabase/visualizations/lib/settings/typed-utils";
import { DEFAULT_VISUALIZATION_THEME } from "metabase/visualizations/shared/utils/theme";
import { LegacyStaticChart } from "./containers/LegacyStaticChart";
......@@ -49,16 +43,7 @@ function getRawSeriesWithDashcardSettings(rawSeries, dashcardSettings) {
}
export function RenderChart(rawSeries, dashcardSettings, colors) {
const getColor = createColorGetter(colors);
const renderingContext = {
getColor,
formatValue,
measureText: (text, style) =>
measureTextWidth(text, style.size, style.weight),
measureTextHeight: (_, style) => measureTextHeight(style.size),
fontFamily: "Lato, 'Helvetica Neue', Helvetica, Arial, sans-serif",
theme: DEFAULT_VISUALIZATION_THEME,
};
const renderingContext = createStaticRenderingContext(colors);
const rawSeriesWithDashcardSettings = getRawSeriesWithDashcardSettings(
rawSeries,
......
import type { ColorPalette } from "metabase/lib/colors/types";
import { DEFAULT_VISUALIZATION_THEME } from "metabase/visualizations/shared/utils/theme";
import type { RenderingContext } from "metabase/visualizations/types";
import { createColorGetter } from "../lib/colors";
import { measureTextHeight, measureTextWidth } from "./text";
export const createStaticRenderingContext = (
colors?: ColorPalette,
): RenderingContext => {
const getColor = createColorGetter(colors);
return {
getColor,
measureText: (text, style) => {
const size =
typeof style.size === "number" ? style.size : parseInt(style.size);
const weight =
typeof style.weight === "number"
? style.weight
: parseInt(style.weight);
if (!isFinite(size) || !isFinite(weight)) {
throw new Error(
`Incompatible for static rendering font style: ${JSON.stringify(
style,
)} `,
);
}
return measureTextWidth(text, size, weight);
},
measureTextHeight: (_, style) =>
measureTextHeight(
typeof style.size === "number" ? style.size : parseInt(style.size),
),
fontFamily: "Lato, 'Helvetica Neue', Helvetica, Arial, sans-serif",
theme: DEFAULT_VISUALIZATION_THEME,
};
};
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment