Skip to content
Snippets Groups Projects
Unverified Commit 096a6af1 authored by Alexander Lesnenko's avatar Alexander Lesnenko Committed by GitHub
Browse files

fix missing visual options on text cards (#22129)

parent 61bb4fc6
No related branches found
No related tags found
No related merge requests found
...@@ -133,7 +133,10 @@ export default class DashCard extends Component { ...@@ -133,7 +133,10 @@ export default class DashCard extends Component {
card.query_average_duration < DATASET_USUALLY_FAST_THRESHOLD, card.query_average_duration < DATASET_USUALLY_FAST_THRESHOLD,
})); }));
const loading = !(series.length > 0 && _.every(series, s => s.data)); const loading =
!(series.length > 0 && _.every(series, s => s.data)) &&
!isVirtualDashCard(dashcard);
const expectedDuration = Math.max( const expectedDuration = Math.max(
...series.map(s => s.card.query_average_duration || 0), ...series.map(s => s.card.query_average_duration || 0),
); );
......
...@@ -36,6 +36,18 @@ describe("scenarios > dashboard > text-box", () => { ...@@ -36,6 +36,18 @@ describe("scenarios > dashboard > text-box", () => {
cy.icon("edit_document"); cy.icon("edit_document");
}); });
it("should render visualization options (metabase#22061)", () => {
showDashboardCardActions(1);
// edit mode
cy.icon("palette")
.eq(1)
.click();
cy.findByText("Vertical Alignment");
cy.findByText("Horizontal Alignment");
});
it("should not render edit and preview actions when not editing", () => { it("should not render edit and preview actions when not editing", () => {
// Exit edit mode and check for edit options // Exit edit mode and check for edit options
cy.findByText("Save").click(); cy.findByText("Save").click();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment