Skip to content
Snippets Groups Projects
Unverified Commit 0bd20d0b authored by Ngoc Khuat's avatar Ngoc Khuat Committed by GitHub
Browse files

Add `parameters` to report_card (#22976)


* add parameters to report_card and card APIs

* make sure migration can work with existing cards and add migration tests

* remove debug code

* When parameters is empty, return template tag parameters

* update schema message

* update migraiton test name

* minor changes in test

* fix failing tests

* Always use card.parameters in PublicQuestion

* Add defaults and readd isEmpty check

* Default to undefined/use template tags in PublicQuestion...

* parameters should be in the writableProperties

* Native query card: construct parameters from template tags

* Separate the generation of parameter id

* Add parameter_mappings to report_card (#23003)

* add parameter_mappings to report_card

* fix from Noah's comments

* fix from Noah's comments

* Update a parameter from an updated template tag

* Correct the parameters construction

* Also add `parameter_mappings` to writableProperties

* CI test: bust the npm module cache

* Revert "CI test: bust the npm module cache"

This reverts commit 5a327b616f0220f43a90f7f871e0bd877ffa6f47.

Co-authored-by: default avatarDalton Johnson <daltojohnso@users.noreply.github.com>
Co-authored-by: default avatarAriya Hidayat <ariya@metabase.com>
parent 6c4b14d5
No related branches found
No related tags found
No related merge requests found
Showing
with 381 additions and 50 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment