use 3rd party angular-cookie library instead of the built-in $cookies because...

use 3rd party angular-cookie library instead of the built-in $cookies because we need to control setting cookie options like path and secure.

use 3rd party angular-cookie library instead of the built-in $cookies because...
0bfad568 · Allen Gilliland · 3338e0ed · 0bfad568 · 0bfad568 · 0bfad568
Commit 0bfad568 authored 10 years ago by Allen Gilliland
--- a/bower.json
+++ b/bower.json
@@ -15,6 +15,7 @@
        "angular-sanitize": "1.2.26",
        "angular-xeditable": "0.1.8",
        "angular-bootstrap": "0.11.0",
+        "angular-cookie": "4.0.6",
        "jquery": "2.1.1",
        "angular-animate": "1.2.26",
        "underscore": "1.7.0",

--- a/frontend_client/app/auth/auth.controllers.js
+++ b/frontend_client/app/auth/auth.controllers.js
@@ -4,9 +4,9 @@
 /*global _*/
 /*global $*/

-var AuthControllers = angular.module('corvus.auth.controllers', ['corvus.services']);
+var AuthControllers = angular.module('corvus.auth.controllers', ['ipCookie', 'corvus.services']);

-AuthControllers.controller('Login', ['$scope', '$cookies', '$location', '$timeout', 'Session', 'AppState', function($scope, $cookies, $location, $timeout, Session, AppState) {
+AuthControllers.controller('Login', ['$scope', '$location', '$timeout', 'ipCookie', 'Session', 'AppState', function($scope, $location, $timeout, ipCookie, Session, AppState) {

    var validEmail = function (email) {
        var re = /^(([^<>()[\]\\.,;:\s@\"]+(\.[^<>()[\]\\.,;:\s@\"]+)*)|(\".+\"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
@@ -14,7 +14,6 @@ AuthControllers.controller('Login', ['$scope', '$cookies', '$location', '$timeou
    }

    $scope.login = function(email, password, remember_me) {
-        // TODO: input validation
        if (!email || !password) {
            $scope.error = "Email address and Password are required.";
            return;
@@ -27,7 +26,9 @@ AuthControllers.controller('Login', ['$scope', '$cookies', '$location', '$timeou
            'email': email,
            'password': password
        }, function (new_session) {
-            $cookies['metabase.SESSION_ID'] = new_session.id;
+            // set a session cookie
+            var isSecure = ($location.protocol() === "https") ? true : false;
+            ipCookie('metabase.SESSION_ID', new_session.id, {path: '/', expires: 14, secure: isSecure});

            // this is ridiculously stupid.  we have to wait (300ms) for the cookie to actually be set in the browser :(
            $timeout(function() {
@@ -52,12 +53,14 @@ AuthControllers.controller('Login', ['$scope', '$cookies', '$location', '$timeou
 }]);


-AuthControllers.controller('Logout', ['$scope', '$cookies', '$location', '$timeout', 'Session', function($scope, $cookies, $location, $timeout, Session) {
+AuthControllers.controller('Logout', ['$scope', '$location', '$timeout', 'ipCookie', 'Session', function($scope, $location, $timeout, ipCookie, Session) {

    // any time we hit this controller just clear out anything session related and move on
-    if ( $cookies['metabase.SESSION_ID'] ) {
-        var sessionId = $cookies['metabase.SESSION_ID'];
-        delete $cookies['metabase.SESSION_ID'];
+    if ( ipCookie('metabase.SESSION_ID') ) {
+        var sessionId = ipCookie('metabase.SESSION_ID');
+
+        // delete the current session cookie
+        ipCookie.remove('metabase.SESSION_ID');

        // this is ridiculously stupid.  we have to wait (300ms) for the cookie to actually be set in the browser :(
        $timeout(function() {

--- a/frontend_client/index.html
+++ b/frontend_client/index.html
 <!DOCTYPE html>
 <html lang="en" ng-app="corvus" class="no-js">
 <head>
-  <base href="/">
  <meta charset="utf-8" />
  <meta http-equiv="X-UA-Compatible" content="IE=edge" />
  <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no, minimal-ui" />
@@ -107,6 +106,7 @@
  <script src="/app/bower_components/angular-animate/angular-animate.min.js"></script>
  <script src="/app/bower_components/angular-sanitize/angular-sanitize.min.js"></script>
  <script src="/app/bower_components/angular-xeditable/dist/js/xeditable.js"></script>
+  <script src="/app/bower_components/angular-cookie/angular-cookie.min.js"></script>
  <script src="/app/bower_components/javascript-detect-element-resize/detect-element-resize.js"></script>
  <script src="/app/bower_components/angular-gridster/src/angular-gridster.js"></script>
  <script src="/app/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js"></script>