-
- Downloads
Run all tests on mysql/h2/postgres app-db tests (#28000)
Originally made all "drivers" tests skip the :mb/once test selected test namespaces. But we use the drivers matrix to test the different app-db types (mysql, postgres). So this moves the `:exclude-tags [:mb/once]` selector off of the drivers job and into particular driver jobs. ```clojure user=> (letfn [(uses-exclude? [[job-name job]] (let [steps (:steps job)] (reduce (fn [uses? step] (if-let [with (:with step)] (if (= ":exclude-tags '[:mb/once]'" (:test-args with)) (reduced true) uses?) uses?)) false steps)))] (-> (group-by uses-exclude? (:jobs (yaml/from-file ".github/workflows/drivers.yml"))) (update-vals (fn [jobs] (map key jobs))))) {true (:be-tests-athena-ee :be-tests-bigquery-cloud-sdk-ee :be-tests-druid-ee :be-tests-googleanalytics-ee :be-tests-mongo-4-2-ee :be-tests-mongo-4-2-ssl-ee :be-tests-mongo-5-0-ee :be-tests-mongo-5-0-ssl-ee :be-tests-mongo-latest-ee :be-tests-oracle-18-4-ee :be-tests-oracle-21-3-ee :be-tests-presto-186-ee :be-tests-presto-jdbc-ee :be-tests-redshift-ee :be-tests-snowflake-ee :be-tests-sparksql-ee :be-tests-sqlite-ee :be-tests-sqlserver-ee :be-tests-vertica-ee), false (:be-tests-google-related-classpath-ee ;; includes an :only selector :be-tests-mariadb-10-2-ee :be-tests-mariadb-latest-ee :be-tests-mysql-5-7-ee :be-tests-mysql-latest-ee :be-tests-postgres-ee :be-tests-postgres-latest-ee)} ``` These maria/mysql/postgres tests all specify `MB_DB_TYPE` so we omit the `exclude-tags` selector to run all tests. The only strange one here is the `:be-tests-google-related-classpath-ee` job which includes an :only selector: ```yaml steps: - uses: actions/checkout@v3 - name: Test Google Related Classpath drivers uses: ./.github/actions/test-driver with: junit-name: 'be-tests-${{ matrix.driver }}-classpath-ee' test-args: ':only "[metabase.query-processor-test.expressions-test metabase.driver.google-test metabase.driver.googleanalytics-test]"' ```
Please register or sign in to comment