Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
0e339238
Commit
0e339238
authored
8 years ago
by
Allen Gilliland
Browse files
Options
Downloads
Patches
Plain Diff
remove stray `replace-params` code. we are going to tackle that at a later time.
parent
445c0340
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/metabase/driver/generic_sql/query_processor.clj
+0
-23
0 additions, 23 deletions
src/metabase/driver/generic_sql/query_processor.clj
with
0 additions
and
23 deletions
src/metabase/driver/generic_sql/query_processor.clj
+
0
−
23
View file @
0e339238
...
...
@@ -298,35 +298,12 @@
(
apply-clauses
driver
(
k/select*
entity
)
inner-query
)))
(
def
^
:private
formatter
(
tf/formatter
"YYYY-MM-dd"
(
t/default-time-zone
)))
;; TODO: we may need to make this part of ISQLDriver interface and let other dbs override as needed
;; Boolean, Long, Double, String, Timestamp
(
defn-
sql-param
"Format a single value properly for inclusion in a SQL statement"
[
param
]
;; TODO: we need to handle sql date/time/timestamp values here (do actual jdbc drivers have functions for this?)
(
cond
(
u/is-temporal?
param
)
(
str
"'"
(
tf/unparse
formatter
(
tc/from-sql-time
param
))
"'"
)
(
string?
param
)
(
str
"'"
param
"'"
)
:else
(
str
param
)))
(
defn-
replace-params
"Replace any positional parameters in a SQL statement `?` with a value from a list of parameters.
e.g. SELECT * FROM mytable WHERE id = ?, [1] -> SELECT * FROM mytable WHERE id = 1"
[
sql
params
]
(
if
(
empty?
params
)
sql
(
let
[
param
(
first
params
)
new-str
(
s/replace-first
sql
#
"\?"
(
sql-param
param
))]
(
replace-params
new-str
(
rest
params
)))))
(
defn
mbql->native
"Transpile MBQL query into a native SQL statement."
[
driver
{{
:keys
[
source-table
]}
:query,
database
:database,
:as
outer-query
}]
(
let
[
entity
((
resolve
'metabase.driver.generic-sql/korma-entity
)
database
source-table
)
korma-form
(
build-korma-form
driver
outer-query
entity
)
form-with-sql
(
kengine/bind-query
korma-form
(
kengine/->sql
korma-form
))]
;; (replace-params (:sql-str form-with-sql) (:params form-with-sql))
{
:query
(
:sql-str
form-with-sql
)
:params
(
:params
form-with-sql
)}))
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment