Malli defn improvements: print the incorrect value in the error (#38062)

* adds info about what value validate got to the exception message

* test fixups

* fix the other test

* remove inline def

src/metabase/util/malli/fn.clj

@@ -150,7 +150,9 @@
 (defn- validate [error-context schema value error-type]
   (when *enforce*
     (when-let [error (mr/explain schema value)]
-      (let [humanized (me/humanize error)
+      (let [humanized (me/humanize error {:wrap (core/fn humanize-include-value
+                                                  [{:keys [value message]}]
+                                                  (str message ", got: " (pr-str value)))})
             details   (merge
                         {:type      error-type
                          :error     error

test/metabase/public_settings/premium_features_test.clj

@@ -181,12 +181,12 @@
       (is (= "Hi rasta, the argument was valid" (greeting-with-schema :rasta)))
 
       (is (thrown-with-msg? clojure.lang.ExceptionInfo
-                            #"Invalid input: \[\"should be a keyword\"\]"
+                            #"Invalid input: \[\"should be a keyword, got: \\\"rasta\\\".*"
                             (greeting-with-schema "rasta"))))
 
    (testing "Return schemas are validated for OSS implementations"
       (is (thrown-with-msg? clojure.lang.ExceptionInfo
-                            #"Invalid output: \[\"should be a keyword\"\]"
+                            #"Invalid output: \[\"should be a keyword, got: \\\"Hi rasta.*"
                             (greeting-with-invalid-oss-return-schema :rasta)))))
 
   (when config/ee-available?
@@ -195,16 +195,15 @@
              (greeting-with-schema :rasta)))
 
       (is (thrown-with-msg? clojure.lang.ExceptionInfo
-                            #"Invalid input: \[\"should be a keyword\"\]"
+                            #"Invalid input: \[\"should be a keyword, got: \\\"rasta\\\".*"
                             (greeting-with-schema "rasta"))))
-
     (testing "Only EE schema is validated if EE implementation is called"
       (is (= "Hi rasta, the schema was valid, and you're running the Enterprise Edition of Metabase!"
              (greeting-with-invalid-oss-return-schema :rasta)))
 
       (mt/with-premium-features #{:custom-feature}
         (is (thrown-with-msg? clojure.lang.ExceptionInfo
-                              #"Invalid output: \[\"should be a keyword\"\]"
+                              #"Invalid output: \[\"should be a keyword, got: \\\"Hi rasta, the schema was valid.*"
                               (greeting-with-invalid-ee-return-schema :rasta)))))
 
     (testing "EE schema is not validated if OSS fallback is called"

test/metabase/util/malli/defn_test.clj

@@ -34,21 +34,22 @@
 
 (deftest ^:parallel mu-defn-test
   (testing "invalid input"
-    (is (=? {:humanized {:x ["missing required key"]
-                         :y ["missing required key"]}}
+    (is (=? {:humanized {:x ["missing required key, got: nil"]
+                         :y ["missing required key, got: nil"]}}
             (try (bar {})
                  (catch Exception e (ex-data e))))
         "when we pass bar an invalid shape um/defn throws"))
 
   (testing "invalid output"
-    (is (=? {:humanized {:x ["should be an int"]
-                         :y ["missing required key"]}}
+    (is (=? {:humanized {:x ["should be an int, got: \"3\""]
+                         :y ["missing required key, got: nil"]}}
             (try (baz)
-                 (catch Exception e (ex-data e))))
+                 (catch Exception e (def eed (ex-data e)) eed)))
         "when baz returns an invalid form um/defn throws")
     (is (= "Inputs: []\n  Return: [:map [:x int?] [:y int?]]"
            (:doc (meta #'baz))))))
 
+
 (mu/defn ^:private boo :- :int "something very important to remember goes here" [_x])
 
 (mu/defn qux-1 [])