-
- Downloads
Friendly revision history messages (#17858)
* Move revision helpers to own directory * Add simple utility to format revision messages * Add messages for basic dashboard cards changes * Handle null values for dashboard card actions * Add basic card series revision message support * Batch multiple changes in a single revision * Add `isValidRevision` helper * Return title and description instead a single string * Filter out unknown fields in revisions * Fix viz settings revision descriptions * Add helpers to revisions unit tests * Use new revision messages util * Filter out invalid or unknown revisions * Capitalize revision descriptions * Wrap new item name with double-quotes * Move revisions unit tests to source code directory * Add basic HistoryModal tests * Add getChangedFields helper * Revert getRevisionMessage return type back to str * Extend isValidRevision check * Fix getRevisionEventsForTimeline work with updated helper * Expsoe revision utils * Use new messages in HistoryModal * Remove getRevisionDescription function * Handle cases when revision's after / before state is null * Simplify getRevisionMessage * Use "description" instead of "message" * Fix dataset_query revision not parsed correctly * Filter out unknown field change types * Support collection_id change event * Return array of changes instead of batching in a single message * Return JSX from getRevisionEventsForTimeline * Fix UI * Remove console.log * Use "rearranged the cards" message * Fix e2e test using old revision messages * Prefer 'after' state to get changed fields * Fix timeline revision event * Fix translations * Add `key` prop to `jt` * Merge revision files * Add an option not to lowercase the capitalize str * Use updated capitalize function * Fix test string * Display question's "display" change messages * [ci nocache] * Fix tests * [ci nocache]
Showing
- frontend/src/metabase/components/HistoryModal.jsx 27 additions, 51 deletionsfrontend/src/metabase/components/HistoryModal.jsx
- frontend/src/metabase/components/HistoryModal.unit.spec.js 106 additions, 0 deletionsfrontend/src/metabase/components/HistoryModal.unit.spec.js
- frontend/src/metabase/components/Timeline.jsx 1 addition, 1 deletionfrontend/src/metabase/components/Timeline.jsx
- frontend/src/metabase/lib/formatting.js 7 additions, 2 deletionsfrontend/src/metabase/lib/formatting.js
- frontend/src/metabase/lib/revisions.js 0 additions, 47 deletionsfrontend/src/metabase/lib/revisions.js
- frontend/src/metabase/lib/revisions/components.jsx 64 additions, 0 deletionsfrontend/src/metabase/lib/revisions/components.jsx
- frontend/src/metabase/lib/revisions/components.unit.spec.js 43 additions, 0 deletionsfrontend/src/metabase/lib/revisions/components.unit.spec.js
- frontend/src/metabase/lib/revisions/index.js 1 addition, 0 deletionsfrontend/src/metabase/lib/revisions/index.js
- frontend/src/metabase/lib/revisions/revisions.js 234 additions, 0 deletionsfrontend/src/metabase/lib/revisions/revisions.js
- frontend/src/metabase/lib/revisions/revisions.unit.spec.js 648 additions, 0 deletionsfrontend/src/metabase/lib/revisions/revisions.unit.spec.js
- frontend/test/metabase/lib/formatting.unit.spec.js 26 additions, 0 deletionsfrontend/test/metabase/lib/formatting.unit.spec.js
- frontend/test/metabase/lib/revisions.unit.spec.js 0 additions, 107 deletionsfrontend/test/metabase/lib/revisions.unit.spec.js
- frontend/test/metabase/scenarios/collections/permissions.cy.spec.js 4 additions, 4 deletions...est/metabase/scenarios/collections/permissions.cy.spec.js
- frontend/test/metabase/scenarios/question/saved.cy.spec.js 2 additions, 2 deletionsfrontend/test/metabase/scenarios/question/saved.cy.spec.js
Loading
Please register or sign in to comment