Skip to content
Snippets Groups Projects
Unverified Commit 1018c5fc authored by Anton Kulyk's avatar Anton Kulyk Committed by GitHub
Browse files

Friendly revision history messages (#17858)

* Move revision helpers to own directory

* Add simple utility to format revision messages

* Add messages for basic dashboard cards changes

* Handle null values for dashboard card actions

* Add basic card series revision message support

* Batch multiple changes in a single revision

* Add `isValidRevision` helper

* Return title and description instead a single string

* Filter out unknown fields in revisions

* Fix viz settings revision descriptions

* Add helpers to revisions unit tests

* Use new revision messages util

* Filter out invalid or unknown revisions

* Capitalize revision descriptions

* Wrap new item name with double-quotes

* Move revisions unit tests to source code directory

* Add basic HistoryModal tests

* Add getChangedFields helper

* Revert getRevisionMessage return type back to str

* Extend isValidRevision check

* Fix getRevisionEventsForTimeline work with updated helper

* Expsoe revision utils

* Use new messages in HistoryModal

* Remove getRevisionDescription function

* Handle cases when revision's after / before state is null

* Simplify getRevisionMessage

* Use "description" instead of "message"

* Fix dataset_query revision not parsed correctly

* Filter out unknown field change types

* Support collection_id change event

* Return array of changes instead of batching in a single message

* Return JSX from getRevisionEventsForTimeline

* Fix UI

* Remove console.log

* Use "rearranged the cards" message

* Fix e2e test using old revision messages

* Prefer 'after' state to get changed fields

* Fix timeline revision event

* Fix translations

* Add `key` prop to `jt`

* Merge revision files

* Add an option not to lowercase the capitalize str

* Use updated capitalize function

* Fix test string

* Display question's "display" change messages

* [ci nocache]

* Fix tests

* [ci nocache]
parent 01f442a8
Branches
Tags
No related merge requests found
Showing
with 1163 additions and 214 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment