Skip to content
Snippets Groups Projects
Unverified Commit 106624a6 authored by flamber's avatar flamber Committed by GitHub
Browse files

Add description icon to public/embed question/dashboard (#12803)

* Show question/dashboard description on public/embeds

* Better position
parent 2dbd0779
Branches
Tags
No related merge requests found
......@@ -16,7 +16,7 @@ const TitleAndDescription = ({ title, description, className }: Attributes) => (
<h2 className="h2 mr1 text-wrap">{title}</h2>
{description && (
<Tooltip tooltip={description} maxWidth={"22em"}>
<Icon name="info" style={{ marginTop: 3 }} />
<Icon name="info" className="mx1" />
</Tooltip>
)}
</div>
......
......@@ -8,6 +8,7 @@ import { parseHashOptions } from "metabase/lib/browser";
import MetabaseSettings from "metabase/lib/settings";
import TitleAndDescription from "metabase/components/TitleAndDescription";
import Parameters from "metabase/parameters/components/Parameters";
import LogoBadge from "./LogoBadge";
......@@ -53,6 +54,7 @@ export default class EmbedFrame extends Component {
const {
className,
children,
description,
actionButtons,
location,
parameters,
......@@ -85,7 +87,9 @@ export default class EmbedFrame extends Component {
>
{name || (parameters && parameters.length > 0) ? (
<div className="EmbedFrame-header flex align-center p1 sm-p2 lg-p3">
{name && <div className="h4 text-bold sm-h3 md-h2">{name}</div>}
{name && (
<TitleAndDescription title={name} description={description} />
)}
{parameters && parameters.length > 0 ? (
<div className="flex ml-auto">
<Parameters
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment