Gh 17910 revision history (#22004)

* Only allow bulk invalidation when there are things to invalidate

* Updating test

* human readable weird logic

* Update frontend/test/metabase/scenarios/question/reproductions/17910-revision-history-update.js

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>

frontend/src/metabase/components/Timeline.jsx

@@ -27,11 +27,17 @@ Timeline.propTypes = {
     }),
   ),
   renderFooter: PropTypes.func,
+  "data-testid": PropTypes.string,
 };
 
 export default Timeline;
 
-function Timeline({ className, items = [], renderFooter }) {
+function Timeline({
+  className,
+  items = [],
+  renderFooter,
+  "data-testid": dataTestId,
+}) {
   const iconSize = 16;
   const halfIconSize = iconSize / 2;
 
@@ -51,6 +57,7 @@ function Timeline({ className, items = [], renderFooter }) {
       leftShift={halfIconSize}
       bottomShift={halfIconSize}
       className={className}
+      data-testid={dataTestId}
     >
       {sortedFormattedItems.map((item, index) => {
         const {

frontend/src/metabase/query_builder/components/QuestionActivityTimeline.jsx

@@ -121,6 +121,7 @@ export function QuestionActivityTimeline({
     >
       <Timeline
         items={events}
+        data-testid="saved-question-history-list"
         renderFooter={item => {
           const { isRevertable, revision } = item;
           if (isRevertable) {

frontend/src/metabase/redux/requests.js

 import { handleActions, createAction } from "redux-actions";
-import { updateIn, assoc } from "icepick";
+import { updateIn, assoc, getIn } from "icepick";
 
 export const setRequestLoading = createAction(
   "metabase/requests/SET_REQUEST_LOADING",
@@ -78,11 +78,21 @@ function requestStateReducerRecursive(state, action) {
   }
 }
 
+const isBulkInvalidation = statePath => {
+  // Bulk invalidations only have a statePath with a length of 2
+  return statePath.length <= 2;
+};
+
 export default (state = {}, action) => {
   if (action && action.payload && action.payload.statePath) {
-    state = updateIn(state, action.payload.statePath, subState =>
-      requestStateReducerRecursive(subState, action),
-    );
+    const statePath = action.payload.statePath;
+    const hasStateToUpdate = !!getIn(state, statePath);
+
+    if (hasStateToUpdate || !isBulkInvalidation(statePath)) {
+      state = updateIn(state, action.payload.statePath, subState =>
+        requestStateReducerRecursive(subState, action),
+      );
+    }
   }
   return state;
 };

frontend/test/metabase/scenarios/question/question-reproductions.cy.spec.js

@@ -18,6 +18,7 @@ import { issue19742 } from "./reproductions/19742-data-picker-closes-after-hidin
 import { issue20551 } from "./reproductions/20551-filter-starts-with";
 import { issue20627 } from "./reproductions/20627-nested-long-names-wrong-aliases";
 import { issue20683 } from "./reproductions/20683-postgres-current-quarter";
+import { issue17910 } from "./reproductions/17910-revision-history-update";
 
 issue4482();
 issue6239();
@@ -39,3 +40,4 @@ issue19742();
 issue20551();
 issue20627();
 issue20683();
+issue17910();

frontend/test/metabase/scenarios/question/reproductions/17910-revision-history-update.js

+import { restore, openOrdersTable, modal } from "__support__/e2e/cypress";
+
+export function issue17910() {
+  describe("issue 17910", () => {
+    beforeEach(() => {
+      restore();
+      cy.signInAsNormalUser();
+    });
+
+    it("revisions should work after creating a question without reloading (metabase#17910)", () => {
+      openOrdersTable();
+      cy.intercept("POST", `/api/card`).as("card");
+      cy.findByText("Save").click();
+      modal().within(() => {
+        cy.findByText("Save").click();
+      });
+      cy.wait("@card");
+      modal().within(() => {
+        cy.findByText("Not now").click();
+      });
+      cy.findByTestId("saved-question-header-button").click();
+      cy.findByText("Add a description").click();
+      modal().within(() => {
+        cy.findByLabelText("Description").type("A description");
+        cy.findByText("Save").click();
+      });
+      cy.findByText("History").click();
+      cy.findByTestId("saved-question-history-list")
+        .children()
+        .should("have.length", 2);
+    });
+  });
+}