Improve slack settings messages (#25379)

frontend/src/metabase/admin/settings/slack/components/SlackSetupForm/SlackSetupForm.tsx

@@ -20,7 +20,7 @@ const SlackSetupForm = ({ onSubmit }: SlackSetupFormProps): JSX.Element => {
           <FormField name="slack-app-token" />
           <FormMessage>
             {t`Finally, open Slack, create a public channel and enter its name below.`}{" "}
-            {t`We'll upload charts and tables here before sending out dashboard subscriptions.`}
+            {t`This channel shouldn't really be used by anyone — we'll upload charts and tables here before sending out dashboard subscriptions (it's a Slack requirement).`}
           </FormMessage>
           <FormField name="slack-files-channel" />
           <FormFooter submitTitle={t`Save changes`} />

frontend/src/metabase/admin/settings/slack/components/SlackStatusForm/SlackStatusForm.tsx

@@ -24,7 +24,7 @@ const SlackStatusForm = ({ settings }: SlackStatusFormProps): JSX.Element => {
           <FormField name="slack-app-token" />
           <FormField
             name="slack-files-channel"
-            description={t`We'll upload charts and tables here before sending out dashboard subscriptions.`}
+            description={t`This channel shouldn't really be used by anyone — we'll upload charts and tables here before sending out dashboard subscriptions (it's a Slack requirement).`}
           />
         </Form>
       )}

frontend/src/metabase/admin/settings/slack/forms.ts

@@ -17,7 +17,7 @@ export const getSlackForm = (
     {
       name: "slack-files-channel",
       type: "input",
-      title: t`Slack channel name`,
+      title: t`Public channel to store image files`,
       placeholder: "metabase_files",
       readOnly,
       validate: (value: string) => !value && t`required`,

frontend/src/metabase/query_builder/components/DataSelector/DataSelectorFieldPicker/DataSelectorFieldPicker.unit.spec.tsx

@@ -2,9 +2,9 @@ import React from "react";
 import { fireEvent, render, screen } from "@testing-library/react";
 import { ORDERS } from "__support__/sample_database_fixture";
 
-import DataSelectorFieldPicker from "./DataSelectorFieldPicker";
 import type { Table } from "metabase-types/api/table";
 import type { Field } from "metabase-types/api/field";
+import DataSelectorFieldPicker from "./DataSelectorFieldPicker";
 
 const props = {
   hasFiltering: true,

frontend/test/metabase/scenarios/admin/settings/settings.cy.spec.js

@@ -284,7 +284,9 @@ describe("scenarios > admin > settings", () => {
 
       cy.findByText("Metabase on Slack");
       cy.findByLabelText("Slack Bot User OAuth Token").type("xoxb");
-      cy.findByLabelText("Slack channel name").type("metabase_files");
+      cy.findByLabelText("Public channel to store image files").type(
+        "metabase_files",
+      );
       cy.button("Save changes").click();
 
       cy.findByText(": invalid token");