Merge pull request #5780 from metabase/fix-cumulative-count-not-working-in-ag-expressions

Fix CumulativeCount expression aggregations not working [ci drivers]

src/metabase/driver/generic_sql/query_processor.clj

@@ -160,7 +160,8 @@
   {:pre [(keyword? aggregation-type)]}
   (if-not field
     ;; aggregation clauses w/o a field
-    (do (assert (= aggregation-type :count)
+    (do (assert (or (= aggregation-type :count)
+                    (= aggregation-type :cumulative-count))
           (format "Aggregations of type '%s' must specify a field." aggregation-type))
         :%count.*)
     ;; aggregation clauses w/ a Field

test/metabase/query_processor_test/expression_aggregations_test.clj

@@ -251,3 +251,13 @@
          :query    {:source-table (data/id :venues)
                     :aggregation  [[:named ["COUNT"] "Count of Things"]]}})
       :data :cols first))
+
+;; check that we can use cumlative count in expression aggregations
+(datasets/expect-with-engines (engines-that-support :expression-aggregations)
+  [[1000]]
+  (format-rows-by [int]
+    (rows (qp/process-query
+            {:database (data/id)
+             :type     :query
+             :query    {:source-table (data/id :venues)
+                        :aggregation  [["*" ["cum_count"] 10]]}}))))