Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
1472a79c
Commit
1472a79c
authored
9 years ago
by
Tom Robinson
Browse files
Options
Downloads
Plain Diff
Merge branch 'master' of github.com:metabase/metabase-init into create_dashboard
parents
ac602116
1ff46b62
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
deploy/deploy_prototype.sh
+4
-7
4 additions, 7 deletions
deploy/deploy_prototype.sh
resources/frontend_client/app/card/card.controllers.js
+6
-6
6 additions, 6 deletions
resources/frontend_client/app/card/card.controllers.js
with
10 additions
and
13 deletions
deploy/deploy_prototype.sh
+
4
−
7
View file @
1472a79c
...
...
@@ -4,13 +4,10 @@ set -eo pipefail
BASEDIR
=
$(
dirname
$0
)
source
"
$BASEDIR
/functions"
if
[
-z
$1
]
;
then
echo
"Oops! You need to specify the name of the EB app version to deploy."
exit
1
fi
EB_VERSION_LABEL
=
$1
EB_ENVIRONMENT
=
metabase-proto
# create EB version
create_eb_version
# deploy EB version to environment
deploy_version
${
EB_ENVIRONMENT
}
${
EB_VERSION_LABEL
}
deploy_version
${
EB_ENVIRONMENT
}
This diff is collapsed.
Click to expand it.
resources/frontend_client/app/card/card.controllers.js
+
6
−
6
View file @
1472a79c
...
...
@@ -480,6 +480,12 @@ CardControllers.controller('CardDetail', [
}
else
{
isObjectDetail
=
false
;
// if we are display bare rows, filter out columns with preview_display = false
if
(
Query
.
isStructured
(
dataset_query
)
&&
Query
.
isBareRowsAggregation
(
dataset_query
.
query
))
{
queryResult
.
data
=
DataGrid
.
filterOnPreviewDisplay
(
queryResult
.
data
);
}
}
// try a little logic to pick a smart display for the data
...
...
@@ -504,12 +510,6 @@ CardControllers.controller('CardDetail', [
card
.
display
=
"
table
"
;
}
// if we are display bare rows, filter out columns with preview_display = false
if
(
Query
.
isStructured
(
dataset_query
)
&&
Query
.
isBareRowsAggregation
(
dataset_query
.
query
))
{
queryResult
.
data
=
DataGrid
.
filterOnPreviewDisplay
(
queryResult
.
data
);
}
renderAll
();
},
function
(
error
)
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment