Skip to content
Snippets Groups Projects
Unverified Commit 154c883e authored by Dalton's avatar Dalton Committed by GitHub
Browse files

Delete unused field utils (#26012)

parent 7fe227db
No related branches found
No related tags found
No related merge requests found
import { UiParameter } from "metabase-lib/lib/parameters/types";
export function hasFieldValues(parameter: UiParameter) {
if ("fields" in parameter) {
return (
Array.isArray(parameter.fields) &&
parameter.fields.some(field => field.hasFieldValues())
);
}
return false;
}
export function hasFields(parameter: UiParameter) {
if ("fields" in parameter) {
return Array.isArray(parameter.fields) && parameter.fields.length > 0;
}
return false;
}
import { createMockUiParameter } from "metabase-lib/lib/parameters/mock";
import Field from "metabase-lib/lib/metadata/Field";
import { hasFieldValues, hasFields } from "./fields";
describe("parameters/utils/fields", () => {
describe("hasFieldValues", () => {
const fieldWithValues = new Field({
values: [1, 2, 3],
});
const fieldWithoutValues = new Field();
it("should be false when the parameter has no fields", () => {
expect(hasFieldValues(createMockUiParameter({ fields: [] }))).toBe(false);
});
it("should be false when fields on the parameter have no values", () => {
expect(
hasFieldValues(createMockUiParameter({ fields: [fieldWithoutValues] })),
).toBe(false);
});
it("should be true when a field on the parameter has values", () => {
expect(
hasFieldValues(
createMockUiParameter({
fields: [fieldWithoutValues, fieldWithValues],
}),
),
).toBe(true);
});
it("should handle a parameter with no fields", () => {
expect(hasFieldValues(createMockUiParameter())).toBe(false);
});
});
describe("hasFields", () => {
it("should be false when the parameter has no fields", () => {
expect(hasFields(createMockUiParameter({ fields: [] }))).toBe(false);
expect(hasFields(createMockUiParameter())).toBe(false);
});
it("should be true when a field on the parameter has values", () => {
const mockField = new Field({ id: 1, name: "foo" });
expect(hasFields(createMockUiParameter({ fields: [mockField] }))).toBe(
true,
);
});
});
});
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment