Skip to content
Snippets Groups Projects
Unverified Commit 1695a18d authored by Cam Saul's avatar Cam Saul Committed by GitHub
Browse files

Redshift CI flake fix: enable robust sync behavior in tests (#45873)

* I think this should fix Redshift test flakes

* PR feedback

* PR feedback

* Make some flaky X-Ray tests ^:mb/once
parent b69d4d5e
No related branches found
No related tags found
No related merge requests found
......@@ -128,7 +128,12 @@
(u/profile (format "%s %s Database %s (reference H2 duration: %s)"
(if full-sync? "Sync" "QUICK sync") driver database-name reference-duration)
;; only do "quick sync" for non `test-data` datasets, because it can take literally MINUTES on CI.
(binding [sync-util/*log-exceptions-and-continue?* false]
;;
;; MEGA SUPER HACK !!! I'm experimenting with this so Redshift tests stop being so flaky on CI! It seems like
;; if we ever delete a table sometimes Redshift still thinks it's there for a bit and sync can fail because it
;; tries to sync a Table that is gone! So enable normal resilient sync behavior for Redshift tests to fix the
;; flakes. If this fixes things I'll try to come up with a more robust solution. -- Cam 2024-07-19. See #45874
(binding [sync-util/*log-exceptions-and-continue?* (= driver :redshift)]
(sync/sync-database! db {:scan (if full-sync? :full :schema)}))
;; add extra metadata for fields
(try
......
(ns metabase.xrays.automagic-dashboards.comparison-test
(ns ^:mb/once metabase.xrays.automagic-dashboards.comparison-test
(:require
[clojure.test :refer :all]
[metabase.models :refer [Card Segment Table]]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment