Skip to content
Snippets Groups Projects
Unverified Commit 17aca2d3 authored by dpsutton's avatar dpsutton Committed by GitHub
Browse files

Parse number filter inputs (#15992)


* Parse number filter inputs

The frontend feels a bit off on this. It's sending `"string/="`
instead of `"number/="` but the backend code knows that number filters
can ignore it. It's also sending strings from the text inputs when it
should be sending number types.

We've had a convention that the types come across as they should be:
numbers come in as numbers and strings as strings. This seems to break
that convention.

* Unskip the "number" part of the repro for #15981

* use normalized parameter values when diffing for dirtiness

* update tag parameter parsing fns to handle number --> number/= types

* tweak & unskip cypress repro test

* wrap fn in parens to invoke it?

Co-authored-by: default avatarNemanja <31325167+nemanjaglumac@users.noreply.github.com>
Co-authored-by: default avatarDalton Johnson <daltojohnso@users.noreply.github.com>
parent 256fd263
Branches
Tags
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment