Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
18bb346d
Unverified
Commit
18bb346d
authored
6 years ago
by
Cam Saul
Browse files
Options
Downloads
Patches
Plain Diff
Test updates
[ci drivers]
parent
0b696457
Loading
Loading
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
resources/migrations/000_migrations.yaml
+26
-6
26 additions, 6 deletions
resources/migrations/000_migrations.yaml
test/metabase/sync/analyze/table_row_count_test.clj
+9
-12
9 additions, 12 deletions
test/metabase/sync/analyze/table_row_count_test.clj
with
35 additions
and
18 deletions
resources/migrations/000_migrations.yaml
+
26
−
6
View file @
18bb346d
...
...
@@ -5148,9 +5148,19 @@ databaseChangeLog:
preConditions
:
-
onFail
:
MARK_RAN
-
onUpdateSQL
:
IGNORE
-
sqlCheck
:
expectedResult
:
0
sql
:
SELECT count(*) FROM (SELECT count(*) FROM METABASE_TABLE GROUP BY DB_ID, SCHEMA, NAME HAVING count(*) > 1) t1
-
or
:
-
and
:
-
dbms
:
type
:
mysql,mariadb
-
sqlCheck
:
expectedResult
:
0
sql
:
SELECT count(*) FROM (SELECT count(*) FROM `metabase_table` GROUP BY `db_id`, `schema`, `name` HAVING count(*) > 1) t1
-
and
:
-
dbms
:
type
:
h2,postgresql
-
sqlCheck
:
expectedResult
:
0
sql
:
SELECT count(*) FROM (SELECT count(*) FROM METABASE_TABLE GROUP BY DB_ID, SCHEMA, NAME HAVING count(*) > 1) t1
changes
:
-
addUniqueConstraint
:
tableName
:
metabase_table
...
...
@@ -5164,9 +5174,19 @@ databaseChangeLog:
preConditions
:
-
onFail
:
MARK_RAN
-
onUpdateSQL
:
IGNORE
-
sqlCheck
:
expectedResult
:
0
sql
:
SELECT count(*) FROM (SELECT count(*) FROM METABASE_FIELD GROUP BY TABLE_ID, PARENT_ID, NAME HAVING count(*) > 1) t1
-
or
:
-
and
:
-
dbms
:
type
:
mysql,mariadb
-
sqlCheck
:
expectedResult
:
0
sql
:
SELECT count(*) FROM (SELECT count(*) FROM `metabase_field` GROUP BY `table_id`, `parent_id`, `name` HAVING count(*) > 1) t1
-
and
:
-
dbms
:
type
:
h2,postgresql
-
sqlCheck
:
expectedResult
:
0
sql
:
SELECT count(*) FROM (SELECT count(*) FROM METABASE_FIELD GROUP BY TABLE_ID, PARENT_ID, NAME HAVING count(*) > 1) t1
changes
:
-
addUniqueConstraint
:
tableName
:
metabase_field
...
...
This diff is collapsed.
Click to expand it.
test/metabase/sync/analyze/table_row_count_test.clj
+
9
−
12
View file @
18bb346d
(
ns
metabase.sync.analyze.table-row-count-test
"Tests for the sync logic that updates a Table's row count."
(
:require
[
metabase
[
query-processor-test
:as
qp-test
]
[
util
:as
u
]]
[
metabase.models.table
:refer
[
Table
]]
(
:require
[
metabase.models.table
:refer
[
Table
]]
[
metabase.query-processor-test
:as
qp-test
]
[
metabase.sync.analyze.table-row-count
:as
table-row-count
]
[
metabase.test.data
:as
data
]
[
metabase.test
[
data
:as
data
]
[
util
:as
tu
]]
[
metabase.test.data.datasets
:as
datasets
]
[
toucan.db
:as
db
]
[
toucan.util.test
:as
tt
]))
[
toucan.db
:as
db
]))
;; test that syncing table row counts works
;; TODO - write a Druid version of this test. Works slightly differently since Druid doesn't have a 'venues' table
;; TODO - not sure why this doesn't work on Oracle. Seems to be an issue with the test rather than with the Oracle driver
(
datasets/expect-with-drivers
(
disj
qp-test/non-timeseries-drivers
:oracle
)
100
(
tt/with-temp
Table
[
venues-copy
(
let
[
venues-table
(
Table
(
data/id
:venues
))]
(
assoc
(
select-keys
venues-table
[
:schema
:name
:db_id
])
:rows
0
))]
(
table-row-count/update-row-count!
venues-copy
)
(
db/select-one-field
:rows
Table
:id
(
u/get-id
venues-copy
))))
(
tu/with-temp-vals-in-db
Table
(
data/id
:venues
)
{
:rows
0
}
(
table-row-count/update-row-count!
(
Table
(
data/id
:venues
)))
(
db/select-one-field
:rows
Table
:id
(
data/id
:venues
))))
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment