Skip to content
Snippets Groups Projects
Commit 198ec1fa authored by Allen Gilliland's avatar Allen Gilliland
Browse files

cleanup a couple final references to the old preview_display attribute

parent 66504d9d
Branches
Tags
No related merge requests found
......@@ -476,7 +476,7 @@ CardControllers.controller('CardDetail', [
} else {
isObjectDetail = false;
// if we are display bare rows, filter out columns with preview_display = false
// if we are display bare rows, filter out columns with visibility_type = details-only
if (Query.isStructured(dataset_query) &&
Query.isBareRowsAggregation(dataset_query.query)) {
queryResult.data = DataGrid.filterOnPreviewDisplay(queryResult.data);
......
......@@ -9,8 +9,8 @@ function compareNumbers(a, b) {
var DataGrid = {
filterOnPreviewDisplay: function(data) {
// find any columns where preview_display = false
var hiddenColumnIdxs = _.map(data.cols, function(col, idx) { if(!col.preview_display) return idx; });
// find any columns where visibility_type = details-only
var hiddenColumnIdxs = _.map(data.cols, function(col, idx) { if(col.visibility_type === "details-only") return idx; });
hiddenColumnIdxs = _.filter(hiddenColumnIdxs, function(val) { return val !== undefined; });
// filter out our data grid using the indexes of the hidden columns
......@@ -25,7 +25,7 @@ var DataGrid = {
});
return {
cols: _.filter(data.cols, function(col) { return col.preview_display; }),
cols: _.filter(data.cols, function(col) { return col.visibility_type !== "details-only"; }),
columns: _.map(data.cols, function(col) { return col.display_name; }),
rows: filteredRows,
rows_truncated: data.rows_truncated
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment