Skip to content
Snippets Groups Projects
Unverified Commit 1c5e1488 authored by Cal Herries's avatar Cal Herries Committed by GitHub
Browse files

Correct sync error handling in redshift tests (#41363)

parent 2051da0b
Branches
Tags
No related merge requests found
......@@ -16,6 +16,7 @@
[metabase.public-settings :as public-settings]
[metabase.query-processor :as qp]
[metabase.sync :as sync]
[metabase.sync.util :as sync-util]
[metabase.test :as mt]
[metabase.test.data.interface :as tx]
[metabase.test.data.redshift :as redshift.test]
......@@ -233,7 +234,8 @@
qual-tbl-nm
qual-view-nm)
;; sync the schema again to pick up the new view (and table, though we aren't checking that)
(sync/sync-database! database {:scan :schema})
(binding [sync-util/*log-exceptions-and-continue?* false]
(sync/sync-database! database {:scan :schema}))
(is (contains?
(t2/select-fn-set :name Table :db_id (u/the-id database)) ; the new view should have been synced
view-nm))
......@@ -262,7 +264,8 @@
"CASE WHEN shop_status = 'open' THEN 11387.133 END AS case_when_numeric_inc_nulls "
"FROM test_data) WITH NO SCHEMA BINDING;")
qual-view-nm)
(sync/sync-database! database {:scan :schema})
(binding [sync-util/*log-exceptions-and-continue?* false]
(sync/sync-database! database {:scan :schema}))
(is (contains?
(t2/select-fn-set :name Table :db_id (u/the-id database)) ; the new view should have been synced without errors
view-nm))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment