Fix native editor flakes (#38755)

e2e/support/helpers/e2e-misc-helpers.js

@@ -37,7 +37,16 @@ export function openNativeEditor({
 
   databaseName && cy.findByText(databaseName).click();
 
-  return cy.findByTestId("native-query-editor").as(alias).should("be.visible");
+  return focusNativeEditor().as(alias);
+}
+
+export function focusNativeEditor() {
+  return cy
+    .findByTestId("native-query-editor")
+    .should("be.visible")
+    .should("have.class", "ace_editor")
+    .click()
+    .should("have.class", "ace_focus");
 }
 
 /**

e2e/test/scenarios/native-filters/helpers/e2e-sql-filter-helpers.js

-import { filterWidget, popover } from "e2e/support/helpers";
+import { filterWidget, focusNativeEditor, popover } from "e2e/support/helpers";
 
 // FILTER TYPES
 
@@ -92,11 +92,7 @@ export function runQuery(xhrAlias = "dataset") {
  * @param {string} query
  */
 export function enterParameterizedQuery(query, options = {}) {
-  // Both delay and a repeated sequence of `{arrowleft}{arrowright}` are there to prevent typing flakes
-  // Without them at least 1 in 10 test runs locally didn't type correctly
-  cy.get("@editor").type("{leftArrow}{rightArrow}{leftArrow}{rightArrow}", {
-    delay: 50,
-  });
+  focusNativeEditor();
   cy.get("@editor").type(query, {
     parseSpecialCharSequences: false,
     ...options,

e2e/test/scenarios/native/reproductions/18148-save-button-before-it-is-possible-to-save.cy.spec.js

@@ -15,11 +15,12 @@ describe("issue 18148", () => {
   });
 
   it("should not offer to save the question before it is actually possible to save it (metabase#18148)", () => {
-    // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
-    cy.findByText("Select a database");
     // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
     cy.findByText("Save").should("have.attr", "aria-disabled", "true");
 
+    // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
+    cy.findByText("Select a database").click();
+
     // eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
     cy.findByText(dbName).click();