Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
1f4d37ff
Unverified
Commit
1f4d37ff
authored
4 years ago
by
Nemanja Glumac
Committed by
GitHub
4 years ago
Browse files
Options
Downloads
Patches
Plain Diff
#14787 Repro: "Distribution" doesn't always work on joined saved question (#14795)
parent
cc8fc112
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
frontend/test/metabase/scenarios/question/nested.cy.spec.js
+48
-0
48 additions, 0 deletions
frontend/test/metabase/scenarios/question/nested.cy.spec.js
with
48 additions
and
0 deletions
frontend/test/metabase/scenarios/question/nested.cy.spec.js
+
48
−
0
View file @
1f4d37ff
...
...
@@ -430,6 +430,54 @@ describe("scenarios > question > nested", () => {
});
});
});
it
.
skip
(
"
'distribution' should work on a joined table from a saved question (metabase#14787)
"
,
()
=>
{
// Set the display really wide and really tall to avoid any scrolling
cy
.
viewport
(
1600
,
1200
);
ordersJoinProducts
(
"
14787
"
);
// This repro depends on these exact steps - it has to be opened from the saved questions
cy
.
visit
(
"
/question/new
"
);
cy
.
findByText
(
"
Simple question
"
).
click
();
cy
.
findByText
(
"
Saved Questions
"
).
click
();
cy
.
findByText
(
"
14787
"
).
click
();
// The column title
cy
.
findByText
(
"
Products → Category
"
).
click
();
cy
.
findByText
(
"
Distribution
"
).
click
();
cy
.
contains
(
"
Summarize
"
).
click
();
cy
.
findByText
(
"
Group by
"
)
.
parent
()
.
within
(()
=>
{
cy
.
log
(
"
**Regression that worked on 0.37.9**
"
);
isSelected
(
"
Products → Category
"
);
});
// Although the test will fail on the previous step, we're including additional safeguards against regressions once the issue is fixed
// It can potentially fail at two more places. See [1] and [2]
cy
.
get
(
"
.Icon-notebook
"
).
click
();
cy
.
get
(
"
[class*=NotebookCellItem]
"
)
.
contains
(
/^Products → Category$/
)
/* [1] */
.
click
();
popover
().
within
(()
=>
{
isSelected
(
"
Products → Category
"
);
/* [2] */
});
/**
* Helper function related to this test only
* TODO:
* Extract it if we have the need for it anywhere else
*/
function
isSelected
(
text
)
{
cy
.
findByText
(
text
)
.
closest
(
"
.List-item
"
)
.
should
(
$el
=>
{
const
className
=
$el
[
0
].
className
;
expect
(
className
).
to
.
contain
(
"
selected
"
);
});
}
});
});
function
ordersJoinProducts
(
name
)
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment