Skip to content
Snippets Groups Projects
Unverified Commit 1f6ff4eb authored by Howon Lee's avatar Howon Lee Committed by GitHub
Browse files

Finishing nits for waterfall static viz (#19868)

Waterfall can now have pretty colors and goals now. Y-axis positions reverted back to the way Dan liked less but is more congruent to the dynamic visualizations.
parent 1b6c1b16
No related branches found
No related tags found
No related merge requests found
......@@ -473,7 +473,8 @@
(def default-y-pos
"Default positions of the y-axes of multiple and combo graphs.
You kind of hope there's only two but here's for the eventuality"
(repeat "left"))
(conj (repeat "right")
"left"))
(def default-combo-chart-types
"Default chart type seq of combo graphs (not multiple graphs)."
......@@ -773,11 +774,17 @@
render-fn (if (isa? (-> cols x-axis-rowfn :effective_type) :type/Temporal)
js-svg/timelineseries-waterfall
js-svg/categorical-waterfall)
settings (-> (->js-viz x-col y-col viz-settings)
(update-in [:colors] assoc
:waterfallTotal (:waterfall.total_color viz-settings)
:waterfallPositive (:waterfall.increase_color viz-settings)
:waterfallNegative (:waterfall.decrease_color viz-settings))
(assoc :showTotal (:waterfall.show_total viz-settings)))
image-bundle (image-bundle/make-image-bundle
render-type
(render-fn rows
labels
(->js-viz x-col y-col viz-settings)))]
settings))]
{:attachments
(when image-bundle
(image-bundle/image-bundle->attachment image-bundle))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment