-
- Downloads
Custom expression: improve the type-checker (#19187)
Use an improved semantic validation layered on top of the existing resolver (around ~40 LoC) instead of its own dedicated logic (~240 LoC). Not only the improved type-checker is leaner and faster, it's also more accurate in some corner cases. The type-checking process is also deferred to the compilation stage, instead of earlier in the parsing stage.
Showing
- frontend/src/metabase/lib/expressions/parser.js 0 additions, 3 deletionsfrontend/src/metabase/lib/expressions/parser.js
- frontend/src/metabase/lib/expressions/process.js 3 additions, 3 deletionsfrontend/src/metabase/lib/expressions/process.js
- frontend/src/metabase/lib/expressions/resolver.js 62 additions, 8 deletionsfrontend/src/metabase/lib/expressions/resolver.js
- frontend/src/metabase/lib/expressions/typechecker.js 0 additions, 243 deletionsfrontend/src/metabase/lib/expressions/typechecker.js
- frontend/test/metabase/lib/expressions/compile.unit.spec.js 0 additions, 181 deletionsfrontend/test/metabase/lib/expressions/compile.unit.spec.js
- frontend/test/metabase/lib/expressions/diagnostics.unit.spec.js 1 addition, 1 deletion...nd/test/metabase/lib/expressions/diagnostics.unit.spec.js
- frontend/test/metabase/lib/expressions/parser.unit.spec.js 0 additions, 15 deletionsfrontend/test/metabase/lib/expressions/parser.unit.spec.js
- frontend/test/metabase/lib/expressions/resolver.unit.spec.js 92 additions, 10 deletionsfrontend/test/metabase/lib/expressions/resolver.unit.spec.js
- frontend/test/metabase/lib/expressions/typechecker.unit.spec.js 12 additions, 226 deletions...nd/test/metabase/lib/expressions/typechecker.unit.spec.js
- frontend/test/metabase/lib/expressions/typeinferencer.unit.spec.js 2 additions, 2 deletions...test/metabase/lib/expressions/typeinferencer.unit.spec.js
- frontend/test/metabase/scenarios/question/reproductions/15714-cc-postgres-percentile-accepts-two-params.cy.spec.js 3 additions, 2 deletions...5714-cc-postgres-percentile-accepts-two-params.cy.spec.js
Loading
Please register or sign in to comment