Skip to content
Snippets Groups Projects
Unverified Commit 2132d4d8 authored by Raphael Krut-Landau's avatar Raphael Krut-Landau Committed by GitHub
Browse files

Disable animation on NewItemMenu (#39712)

parent 9413706b
No related branches found
No related tags found
No related merge requests found
......@@ -57,13 +57,15 @@ class EntityMenu extends Component {
renderTrigger,
triggerAriaLabel,
tooltipPlacement,
transitionDuration = 150,
} = this.props;
const { open, menuItemContent } = this.state;
return (
<Popover
opened={open}
className={cx(className, open ? openClassNames : closedClassNames)}
transitionProps={{ transition: "fade" }}
transitionProps={{ duration: transitionDuration }}
onChange={() => this.toggleMenu()}
position="bottom-end"
>
......
......@@ -156,6 +156,11 @@ const NewItemMenu = ({
trigger={trigger}
triggerIcon={triggerIcon}
tooltip={triggerTooltip}
// I've disabled this transition, since it results in the menu
// sometimes not appearing until content finishes loading on complex
// dashboards and questions #39303
// TODO: Try to restore this transition once we upgrade to React 18 and can prioritize this update
transitionDuration={0}
/>
{modal && (
<>
......
......@@ -97,6 +97,11 @@ function ProfileLink({ adminItems, onLogout }) {
color: color("text-white"),
},
}}
// I've disabled this transition, since it results in the menu
// sometimes not appearing until content finishes loading on complex
// dashboards and questions #39303
// TODO: Try to restore this transition once we upgrade to React 18 and can prioritize this update
transitionDuration={0}
/>
{modalOpen === "about" ? (
<Modal small onClose={closeModal}>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment