Skip to content
Snippets Groups Projects
Unverified Commit 2167b788 authored by Noah Moss's avatar Noah Moss Committed by GitHub
Browse files

Migrate LDAP code to using `defenterprise` (#21687)

* scaffolding, docstring & arg parsing

* tweaks

* registry and basic oss->ee dispatch

* stubbed defenterprise-ee

* full defenterprise-ee impl

* fix build and tweak docstring

* remove debug code

* basic tests

* use defonce

* support for :any feature

* schema support

* fix schema test

* switch to using format

* support for schema on return val

* tweak macro

* move schema validation to submacros

* do ee fn resolution at runtime

* do conditionals at macro-expansion time

* adjust semantics & refactor

* fix test

* add memoization for ee resolution

* fix tests

* emit register-mapping! call to avoid eval

* call starts-with on symbol

* remove schema support

* use spec for arg parsing, generate fns, and remove :error fallback option

* clean ns

* change schema alias to schema

* add :arglists meta and small refactor

* refactor

* move EE logic to fn

* validate that the correct args are passed in EE/OSS namespaces, and make :feature required

* remove logic for handling nil :feature

* fix lint errors

* fix ee macros

* defenterprise-schema macro & tests

* clean ns

* propogate metadata

* don't memoize ee resolution in dev to make debugging easier

* dont do ee fn resolution during macroexpansion

* migrate LDAP functions to defenterprise

* lint

* require ee ns separately so that EE settings are available

* revert change to function mocked in tests

* add back code lost in merge

* clean ns

* clean ns again

* minor refactor and cleanup

* major refactor

* fix defenterprise-schema syntax

* fix import

* major refactor

* update docstrings

* more docstring tweaks

* try to fix lint error on ldap PR

* add lint-as mappings for defenterprise and defenterprise-schema to clj-kondo config

* clj-kondo/ignore use of spec alias

* use destructuring in arg lists since it's now supported

* add docstring to def emitted by macro, and some formatting tweaks
parent f4e49dbd
Branches
Tags
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment