Resolved conflict (#51070)

Co-authored-by: Nathan Voxland <nathan@metabase.com>

src/metabase/server/middleware/offset_paging.clj

@@ -21,9 +21,16 @@
   Automatically generated by a handler in offset-paging middleware."
   false)
 
+(defn- ensure-single-value
+  "For parameters that should have a single value, only return the 1st if multiple values were passed in the request"
+  [v]
+  (if (sequential? v)
+    (first v)
+    v))
+
 (defn- parse-paging-params [{{:strs [limit offset]} :query-params}]
-  (let [limit  (some-> limit parse-long)
-        offset (some-> offset parse-long)]
+  (let [limit  (some-> limit ensure-single-value parse-long)
+        offset (some-> offset ensure-single-value parse-long)]
     (when (or limit offset)
       {:limit (or limit default-limit), :offset (or offset default-offset)})))
 

test/metabase/query_processor_test/offset_test.clj

@@ -310,3 +310,11 @@
                  (mt/formatted-rows
                   [->local-date 2.0]
                   (qp/process-query query)))))))))
+
+(deftest multiple-limits
+  (let [total-count (-> (mt/user-real-request :crowberto :get 200 "search?q=product")
+                        :data count)
+        result-count (-> (mt/user-real-request :crowberto :get 200 "search?q=product&limit=1&limit=3")
+                         :data count)]
+    (is (>= total-count result-count))
+    (is (= 1 result-count))))

test/metabase/server/middleware/offset_paging_test.clj

@@ -46,6 +46,13 @@
                        "paged?" true
                        "params" {"whatever" "true"}}}
             (read-response (handler (ring.mock/request :get "/" {:offset "200", :limit "100", :whatever "true"}))))))
+  (testing "w/duplicate paging params"
+    (is (=? {:status 200
+             :body {"limit" 100
+                    "offset" 200
+                    "paged?" true
+                    "params" {"whatever", "true"}}}
+            (read-response (handler (ring.mock/request :get  "/" {:offset ["200", "250"], :limit ["100" "150"], :whatever "true"}))))))
   (testing "w/ non-numeric paging params, paging is disabled"
     (is (=? {:status 200
              :body {"limit"  nil