Skip to content
Snippets Groups Projects
Unverified Commit 223708bd authored by Dalton's avatar Dalton Committed by GitHub
Browse files

Normalize virtual card table fields using its `table_id` and `id` (#25267)

* Update FieldSchema to store virtual card table fields using both table_id and field id

* Update the metadata selector to look use field's uniqueId property

* Add tableId arg to Metadata.prototype.field method

* Normalize fields in sample_database_fixture

* Fix incorrect e2e test

* Make the second arg of field optional

* Pull out small fn

* Refactoring + clean up + mocks & tests

* Update metadata.field(...) usage in a few places

* Revert FieldDimension change

* Move complex FieldDimension `field` logic to the instantiation of "virtual" fields by the associated query's `table` method (#25109)

* Add merge method to Field

* add new virtual table utils + tests

* Use new utils in implementation of Structured/NativeQuery table methods + remove unneeded Dimension logic

* let all Questions return dependentMetadata

* Fix types related to query.table() potentially returning null

* Fix updateQuestion tests

* Remove unused Dimension imports

* Fix issue resolving rootTable on queries based on virtual tables

* Fallback to the nested card table stored in the Metadata instance

* Make the nested card Table the main driver in returning fields for nested cards + other misc fixes

* more tweaks related to cloned Tables, source queries

* Don't clobber metadata if something is already there (like a method named 'metadata')

* Fix for nested native query

* Don't use real table for source query

* Update table code to use the actual nested card table fields instead of doing merge logic

* Skip an e2e test

* Workaround for getting Dimensions from joins

* Update arg name

* Try removing the Table fetch from Question's dependentMetadata method

* Don't rerun query when converting question to model

* Fix for source query not showing 'previous results'

* Fix unit tests

* Update models e2e tests not to wait on query

* Unskip repro for #23449

* make sure a join's joinedQuery is not a dataset/model

* use createQuestion in e2e test

* don't use Question redux dispatch method for updating

* split test cases

* Add comment
parent aaf93a0b
No related branches found
No related tags found
No related merge requests found
Showing
with 830 additions and 191 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment