-
- Downloads
Fix flakiness in `scatter` visualization tests (#15520)
- Fixes a flake in scatter.cy.spec.js that started appearing after throttle was introduced to the ExplicitSize component in #15235 - Also fixes a flake with brush filter that apparently wasn't fully fixed in the previous attempt ## Additional Info: - Stress testing this fix in isolation with GitHub actions shows 20/20 runs passing- Stress testing "brush date filter" revealed that it still fails approximately 4-5x out of 20! - The reason seems to be that `mouseup` event doesn't always happen at the same time so the resulting filter doesn't have the same ending month every time (for example I've seen: "Created At between May, 2016 September, 2016", "Created At between May, 2016 July, 2016" and even "Created At between May, 2016 May, 2016") - It is more than enough that we assert that this filter exists in the first place so I changed the assertion to: `cy.contains(/^Created At between May, 2016/);` since the beginning of this string is the only thing we care about
Showing
- frontend/test/metabase/scenarios/visualizations/drillthroughs/chart_drill.cy.spec.js 5 additions, 3 deletions...arios/visualizations/drillthroughs/chart_drill.cy.spec.js
- frontend/test/metabase/scenarios/visualizations/scatter.cy.spec.js 16 additions, 12 deletions...test/metabase/scenarios/visualizations/scatter.cy.spec.js
Please register or sign in to comment