Skip to content
Snippets Groups Projects
Commit 2363c420 authored by Kyle Doherty's avatar Kyle Doherty
Browse files

remove tests for data ref functionality that was removed

parent ad727dd5
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
frontend/test/query_builder/components/dataref/FieldPane.integ.spec.js
+ 0
− 51
View file @ 2363c420
......@@ -9,18 +9,12 @@ import { mount } from "enzyme";
import {
INITIALIZE_QB,
QUERY_COMPLETED,
setQuerySourceTable,
TOGGLE_DATA_REFERENCE,
} from "metabase/query_builder/actions";
import { delay } from "metabase/lib/promise";
import QueryBuilder from "metabase/query_builder/containers/QueryBuilder";
import DataReference from "metabase/query_builder/components/dataref/DataReference";
import { FETCH_TABLE_METADATA } from "metabase/redux/metadata";
import QueryButton from "metabase/components/QueryButton";
import Table from "metabase/visualizations/visualizations/Table";
import UseForButton from "metabase/query_builder/components/dataref/UseForButton";
import * as Urls from "metabase/lib/urls";
// Currently a lot of duplication with FieldPane tests
......@@ -47,50 +41,5 @@ describe("FieldPane", () => {
const dataReference = queryBuilder.find(DataReference);
expect(dataReference.length).toBe(1);
click(dataReference.find('a[children="Orders"]'));
// TODO: Refactor TablePane so that it uses redux/metadata actions instead of doing inlined API calls
// then we can replace this with `store.waitForActions([FETCH_TABLE_FOREIGN_KEYS])` or similar
await delay(3000);
click(dataReference.find(`a[children="Created At"]`).first());
await store.waitForActions([FETCH_TABLE_METADATA]);
});
it("lets you group by Created At", async () => {
const getUseForButton = () =>
queryBuilder.find(DataReference).find(UseForButton);
expect(getUseForButton().length).toBe(0);
await store.dispatch(setQuerySourceTable(1));
// eslint-disable-line react/no-irregular-whitespace
expect(getUseForButton().text()).toMatch(/Group by/);
click(getUseForButton());
await store.waitForActions([QUERY_COMPLETED]);
// after the breakout has been applied, the button shouldn't be visible anymore
expect(getUseForButton().length).toBe(0);
});
it("lets you see all distinct values of Created At", async () => {
const distinctValuesButton = queryBuilder
.find(DataReference)
.find(QueryButton)
.at(0);
try {
click(distinctValuesButton.children().first());
} catch (e) {
// QueryButton uses react-router Link which always throws an error if it's called without a parent Router object
// Now we are just using the onClick handler of Link so we don't have to care about that
}
await store.waitForActions([QUERY_COMPLETED]);
expect(queryBuilder.find(Table).length).toBe(1);
});
});
frontend/test/query_builder/components/dataref/MetricPane.integ.spec.js deleted 100644 → 0
+ 0
− 89
View file @ ad727dd5
import {
useSharedAdminLogin,
createTestStore,
cleanup,
} from "__support__/integrated_tests";
import { click } from "__support__/enzyme_utils";
import React from "react";
import { mount } from "enzyme";
import {
INITIALIZE_QB,
QUERY_COMPLETED,
TOGGLE_DATA_REFERENCE,
} from "metabase/query_builder/actions";
import { delay } from "metabase/lib/promise";
import QueryBuilder from "metabase/query_builder/containers/QueryBuilder";
import DataReference from "metabase/query_builder/components/dataref/DataReference";
import { vendor_count_metric } from "__support__/sample_dataset_fixture";
import { FETCH_TABLE_METADATA } from "metabase/redux/metadata";
import QueryDefinition from "metabase/query_builder/components/dataref/QueryDefinition";
import QueryButton from "metabase/components/QueryButton";
import Scalar from "metabase/visualizations/visualizations/Scalar";
import * as Urls from "metabase/lib/urls";
import { MetricApi } from "metabase/services";
describe("MetricPane", () => {
let store = null;
let queryBuilder = null;
beforeAll(async () => {
useSharedAdminLogin();
cleanup.metric(await MetricApi.create(vendor_count_metric));
store = await createTestStore();
store.pushPath(Urls.plainQuestion());
queryBuilder = mount(store.connectContainer(<QueryBuilder />));
await store.waitForActions([INITIALIZE_QB]);
});
afterAll(cleanup);
// NOTE: These test cases are intentionally stateful
// (doing the whole app rendering thing in every single test case would probably slow things down)
it("opens properly from QB", async () => {
// open data reference sidebar by clicking button
click(queryBuilder.find(".Icon-reference"));
await store.waitForActions([TOGGLE_DATA_REFERENCE]);
const dataReference = queryBuilder.find(DataReference);
expect(dataReference.length).toBe(1);
click(dataReference.find('a[children="Products"]'));
// TODO: Refactor TablePane so that it uses redux/metadata actions instead of doing inlined API calls
// then we can replace this with `store.waitForActions([FETCH_TABLE_FOREIGN_KEYS])` or similar
await delay(3000);
click(
dataReference.find(`a[children="${vendor_count_metric.name}"]`).first(),
);
await store.waitForActions([FETCH_TABLE_METADATA]);
});
it("shows you the correct definition", () => {
const queryDefinition = queryBuilder
.find(DataReference)
.find(QueryDefinition);
expect(queryDefinition.text()).toMatch(/Number of distinct valuesofVendor/);
});
it("lets you see the vendor count", async () => {
const queryButton = queryBuilder.find(DataReference).find(QueryButton);
try {
click(queryButton.children().first());
} catch (e) {
// QueryButton uses react-router Link which always throws an error if it's called without a parent Router object
// Now we are just using the onClick handler of Link so we don't have to care about that
}
await store.waitForActions([QUERY_COMPLETED]);
expect(queryBuilder.find(Scalar).text()).toBe("200");
});
});
frontend/test/query_builder/components/dataref/SegmentPane.integ.spec.js deleted 100644 → 0
+ 0
− 133
View file @ ad727dd5
import {
useSharedAdminLogin,
createTestStore,
cleanup,
} from "__support__/integrated_tests";
import { click } from "__support__/enzyme_utils";
import React from "react";
import { mount } from "enzyme";
import {
INITIALIZE_QB,
LOAD_TABLE_METADATA,
QUERY_COMPLETED,
setQuerySourceTable,
TOGGLE_DATA_REFERENCE,
} from "metabase/query_builder/actions";
import { delay } from "metabase/lib/promise";
import QueryBuilder from "metabase/query_builder/containers/QueryBuilder";
import DataReference from "metabase/query_builder/components/dataref/DataReference";
import { orders_past_300_days_segment } from "__support__/sample_dataset_fixture";
import { FETCH_TABLE_METADATA } from "metabase/redux/metadata";
import QueryDefinition from "metabase/query_builder/components/dataref/QueryDefinition";
import QueryButton from "metabase/components/QueryButton";
import Table from "metabase/visualizations/visualizations/Table";
import UseForButton from "metabase/query_builder/components/dataref/UseForButton";
import { SegmentApi } from "metabase/services";
import * as Urls from "metabase/lib/urls";
// Currently a lot of duplication with SegmentPane tests
describe("SegmentPane", () => {
let store = null;
let queryBuilder = null;
beforeAll(async () => {
useSharedAdminLogin();
cleanup.segment(await SegmentApi.create(orders_past_300_days_segment));
store = await createTestStore();
store.pushPath(Urls.plainQuestion());
queryBuilder = mount(store.connectContainer(<QueryBuilder />));
await store.waitForActions([INITIALIZE_QB]);
});
afterAll(cleanup);
// NOTE: These test cases are intentionally stateful
// (doing the whole app rendering thing in every single test case would probably slow things down)
it("opens properly from QB", async () => {
// open data reference sidebar by clicking button
click(queryBuilder.find(".Icon-reference"));
await store.waitForActions([TOGGLE_DATA_REFERENCE]);
const dataReference = queryBuilder.find(DataReference);
expect(dataReference.length).toBe(1);
click(dataReference.find('a[children="Orders"]'));
// TODO: Refactor TablePane so that it uses redux/metadata actions instead of doing inlined API calls
// then we can replace this with `store.waitForActions([FETCH_TABLE_FOREIGN_KEYS])` or similar
await delay(3000);
click(
dataReference
.find(`a[children="${orders_past_300_days_segment.name}"]`)
.first(),
);
await store.waitForActions([FETCH_TABLE_METADATA]);
});
it("shows you the correct segment definition", () => {
const queryDefinition = queryBuilder
.find(DataReference)
.find(QueryDefinition);
// eslint-disable-next-line no-irregular-whitespace
expect(queryDefinition.text()).toMatch(/Created AtPast 300 Days/);
});
it("lets you apply the filter to your current query", async () => {
await store.dispatch(setQuerySourceTable(1));
await store.waitForActions(LOAD_TABLE_METADATA);
const filterByButton = queryBuilder
.find(DataReference)
.find(UseForButton)
.first();
click(filterByButton.children().first());
await store.waitForActions([QUERY_COMPLETED]);
expect(queryBuilder.find(DataReference).find(UseForButton).length).toBe(0);
});
it("lets you see count of rows for past 300 days", async () => {
const numberQueryButton = queryBuilder
.find(DataReference)
.find(QueryButton)
.at(0);
try {
click(numberQueryButton.children().first());
} catch (e) {
// QueryButton uses react-router Link which always throws an error if it's called without a parent Router object
// Now we are just using the onClick handler of Link so we don't have to care about that
}
await store.waitForActions([QUERY_COMPLETED]);
// The value changes daily which wasn't originally taken into account
// expect(queryBuilder.find(Scalar).text()).toBe("1,236")
});
it("lets you see raw data for past 300 days", async () => {
const allQueryButton = queryBuilder
.find(DataReference)
.find(QueryButton)
.at(1);
try {
click(allQueryButton.children().first());
} catch (e) {
// QueryButton uses react-router Link which always throws an error if it's called without a parent Router object
// Now we are just using the onClick handler of Link so we don't have to care about that
}
await store.waitForActions([QUERY_COMPLETED]);
expect(queryBuilder.find(Table).length).toBe(1);
});
});
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment