Dashboard Param Values Common Impl for Embedding/Preview Embedding (#42052)
* Dashboard Param Values Common Impl for Embedding/Preview Embedding Refactor the embedding api namespace to allow a bit of reuse between the embedding api and the embedding preview api. In some cases, the implementations are not identical (in terms of the shape of data expected/endpoints available), so this is a first step to making them the same. Related: https://www.notion.so/metabase/Make-embedding-preview-behave-consistently-with-actual-static-embeds-855353d8e5e8411d8164c7ac563c7d2f * Add a test to verify that preview-embed param-values endpoint works * Use preview embed endpoint and fix relevant tests * Add tests * Change name to reflect what actually happens in the function --------- Co-authored-by:Mahatthana Nomsawadi <mahatthana.n@gmail.com>
Showing
- e2e/test/scenarios/embedding/reproductions/37914-41635-embed-preview-parameter-values.cy.spec.js 233 additions, 0 deletions...ons/37914-41635-embed-preview-parameter-values.cy.spec.js
- e2e/test/scenarios/embedding/reproductions/40660-overflow-when-embedding-long-dashboards.cy.spec.js 0 additions, 1 deletion.../40660-overflow-when-embedding-long-dashboards.cy.spec.js
- frontend/src/metabase/dashboard/actions/data-fetching.js 1 addition, 2 deletionsfrontend/src/metabase/dashboard/actions/data-fetching.js
- frontend/src/metabase/services.js 9 additions, 1 deletionfrontend/src/metabase/services.js
- src/metabase/api/embed.clj 21 additions, 467 deletionssrc/metabase/api/embed.clj
- src/metabase/api/embed/common.clj 478 additions, 0 deletionssrc/metabase/api/embed/common.clj
- src/metabase/api/preview_embed.clj 19 additions, 14 deletionssrc/metabase/api/preview_embed.clj
- test/metabase/api/embed_test.clj 14 additions, 14 deletionstest/metabase/api/embed_test.clj
- test/metabase/api/preview_embed_test.clj 46 additions, 0 deletionstest/metabase/api/preview_embed_test.clj
Loading
Please register or sign in to comment